[16][IMP] account_ecotax: Add ecotax only if it match shipping address country #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @mourad-ehm, |
mourad-ehm
approved these changes
Mar 20, 2025
florian-dacosta
force-pushed
the
16-ecotax-product-country
branch
2 times, most recently
from
32f32b1 to
facc9cc
Compare
Contributor
|
This PR has the |
florian-dacosta
force-pushed
the
16-ecotax-product-country
branch
2 times, most recently
from
1bf77bf to
578a321
Compare
hparfr
reviewed
Aug 7, 2025
computing the product ecotax passing partner country in context does not work well because sometimes we cant have the country passed. For example in account.move.line._compute_totals, sometimes we do not have the context and the tax is wrongly computed because of an empty ecotax amount. Refactore to set or not the ecotax tax on the sale/invoice line depending on the country. It is more limited because it means than a same product can only have classification for a same set of country, but it is more reliable.
florian-dacosta
force-pushed
the
16-ecotax-product-country
branch
from
578a321 to
c482033
Compare
florian-dacosta
force-pushed
the
16-ecotax-product-country
branch
from
d5dcc4f to
c482033
Compare
dreispt
approved these changes
Dec 7, 2025
dreispt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.