-
-
Notifications
You must be signed in to change notification settings - Fork 204
[18.0][MIG] account_product_fiscal_classification: Migration to 18.0 #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
P-H-Phuc
wants to merge
164
commits into
OCA:18.0
Choose a base branch
from
P-H-Phuc:18.0_mig_account_product_fiscal_classification
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] account_product_fiscal_classification: Migration to 18.0 #546
P-H-Phuc
wants to merge
164
commits into
OCA:18.0
from
P-H-Phuc:18.0_mig_account_product_fiscal_classification
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired for the Brazilian localization)
…pass the ir.rule.group refactoring
… messing with product taxes from an other (sub) company
… added company_id.id parameter in search method in account.tax objects
…t_product_fiscal_classification and account_fiscal_position_rule and remove old files __terp__.py
…cts do not require any fiscal classification
…toring and changed in account_product_fiscal_classification module product.product to product.template
…ification changed header files and included in __openerp__.py explicit AGPL-3 license
… in Fiscal Classification
…nt_product_fiscal_classification
…methods in in object account.product.fiscal.classification
…nly called at the installation, and no during update anymore;
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/
Currently translated at 100.0% (55 of 55 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/es/
Currently translated at 100.0% (55 of 55 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/fr/
…alled, having default has no sense. It also generate error when mass importing, if the default values doesn't match with a fiscal classification. As a result, in a demo database, installing a module that create a product when account_product_fiscal_classification is installed will fail
Currently translated at 100.0% (55 of 55 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/sv/
Currently translated at 100.0% (55 of 55 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/
Currently translated at 100.0% (59 of 59 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/it/
Currently translated at 100.0% (59 of 59 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/sv/
- In a context of product creation, if classification is not provided (in import context for exemple),
link the products to an existing classification, if the taxes match an existing one.
If no classification match, try to create a new classification, based on the product fiscal settings.
(It will fail if user is not member of Accountant group that can create / write on fiscal classifications)
- In a context of product update, apply same logic, linking to existing classification, or creating new classification
This will fix current limitation if account_product_fiscal_classification and pos_sale (for exemple) is installed,
there is an error when making an update, because loading data / demo is failing for the time being if the fields
taxes_id or supplier_taxes_id is defined. See for exemple : pos_sale.default_downpayment_product that contains
{'taxes_id': '[(5,)]'} write.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/
2f88ee8 to
a9bdb60
Compare
a9bdb60 to
0b3bbb8
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module extends the Odoo Account module to introduce Fiscal Classifications.
A fiscal classification is an association of purchase and sale taxes that have to be set on your products.
This new design provides the following improvments.
It is more simple (less clicks quantity) to configure correctly a product. (You only have to set a fiscal classification, instead of setting one or many sale taxes, then click on purchase tab and set one or many purchase taxes.)
Prevent users to select incompatible purchase and sale taxes. French Exemple: A product can not be configured with:
Optionaly, you can restrict the usage of some fiscal classifications to some product categories. French Exemple : A product set in the category
Beer and winecan not have a sale tax 5,5%. (20% is mandatory)Configuration
Optional settings
Once the fiscal classifications are created, you can create rules to avoid users to use some classifications that don't make sense for some categories.
Every time a new product is created, the rules that matches the product setting will be checked in the displayed order.
Note
Since Odoo 17.0, the
account.chart.templatemodel was refactored: it is now defined as anAbstractModel, not as aModel.Remove test chart.template