-
-
Notifications
You must be signed in to change notification settings - Fork 204
[IMP] account_fiscal_position_vies_warning: added condition for show vies warning #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] account_fiscal_position_vies_warning: added condition for show vies warning #566
Conversation
|
Hi @rafaelbn, @Andrii9090, |
EmilioPascual
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…vies warning MT-13115
7c7e95f to
dc73365
Compare
|
@EmilioPascual I have corrected this, could you please check it again? |
EmilioPascual
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @sabrinaRMartin. @rafaelbn @Andrii9090 can you review it and merge it, please? Thanks
Andrii9090
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This PR has the |
Gelojr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this contribution @sabrinaRMartin !
The following tests were performed:
- Test 1: Attempted to save a partner without VIES validation using a fiscal position with “Show Vies Warning”; Odoo raised the warning and the record could not be saved (OK).
- Test 2: Saved a partner with a VIES-valid VAT using a fiscal position with “Show Vies Warning”; the partner was saved successfully (OK).
- Test 3: Saved a partner without VIES validation using a fiscal position without “Show Vies Warning”; the partner was saved successfully (OK).
- Test 4: Created an invoice for a non-VIES partner with a fiscal position with “Show Vies Warning” and attempted to post; posting was blocked with the warning (OK).
- Test 5: Created an invoice for a VIES-valid partner with a fiscal position with “Show Vies Warning” and posted; the invoice was posted successfully (OK).
- Test 6: Disabled “Show Vies Warning” on the fiscal position and retried saving a non-VIES partner with that position; saving was allowed (OK).
- Test 7: Disabled “Verify VAT Numbers” in settings and retried saving/posting with a warned fiscal position; no warnings appeared and both save and post proceeded (OK).
- Test 8: Verified field visibility so that “Show Vies Warning” is visible only when auto_apply and vat_required are enabled on the fiscal position and “Verify VAT Numbers” is enabled on the company; otherwise it remains hidden (OK).
|
@Andrii9090 as maintainer can you merge? |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 05caee6. Thanks a lot for contributing to OCA. ❤️ |




The “Show VIES warning” field now only appears if the “Automatically detect” and “Requires VAT” checks are enabled and the company has VIES enabled.
MT-13115 @moduon @EmilioPascual
https://www.loom.com/share/82ddd16d593540d39587f4eec2fd11c1