Skip to content

Conversation

@sabrinaRMartin
Copy link
Contributor

@sabrinaRMartin sabrinaRMartin commented Dec 18, 2025

The “Show VIES warning” field now only appears if the “Automatically detect” and “Requires VAT” checks are enabled and the company has VIES enabled.

MT-13115 @moduon @EmilioPascual

https://www.loom.com/share/82ddd16d593540d39587f4eec2fd11c1

imagen imagen

@OCA-git-bot
Copy link
Contributor

Hi @rafaelbn, @Andrii9090,
some modules you are maintaining are being modified, check this out!

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With VIES unchecked in company, the field is displayed
image
image

This field shouldn`t be displayed if VIES is enable

@sabrinaRMartin sabrinaRMartin force-pushed the 18.0-imp-account_fiscal_position_vies_warning branch from 7c7e95f to dc73365 Compare December 19, 2025 11:44
@sabrinaRMartin
Copy link
Contributor Author

@EmilioPascual I have corrected this, could you please check it again?

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @sabrinaRMartin. @rafaelbn @Andrii9090 can you review it and merge it, please? Thanks

Copy link
Contributor

@Andrii9090 Andrii9090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabrinaRMartin good job! Code and functional review 👍

Image Image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this contribution @sabrinaRMartin !
The following tests were performed:

  • Test 1: Attempted to save a partner without VIES validation using a fiscal position with “Show Vies Warning”; Odoo raised the warning and the record could not be saved (OK).
  • Test 2: Saved a partner with a VIES-valid VAT using a fiscal position with “Show Vies Warning”; the partner was saved successfully (OK).
  • Test 3: Saved a partner without VIES validation using a fiscal position without “Show Vies Warning”; the partner was saved successfully (OK).
  • Test 4: Created an invoice for a non-VIES partner with a fiscal position with “Show Vies Warning” and attempted to post; posting was blocked with the warning (OK).
  • Test 5: Created an invoice for a VIES-valid partner with a fiscal position with “Show Vies Warning” and posted; the invoice was posted successfully (OK).
  • Test 6: Disabled “Show Vies Warning” on the fiscal position and retried saving a non-VIES partner with that position; saving was allowed (OK).
  • Test 7: Disabled “Verify VAT Numbers” in settings and retried saving/posting with a warned fiscal position; no warnings appeared and both save and post proceeded (OK).
  • Test 8: Verified field visibility so that “Show Vies Warning” is visible only when auto_apply and vat_required are enabled on the fiscal position and “Verify VAT Numbers” is enabled on the company; otherwise it remains hidden (OK).

@EmilioPascual
Copy link

@Andrii9090 as maintainer can you merge?

@Andrii9090
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-566-by-Andrii9090-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9b29008 into OCA:18.0 Jan 7, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 05caee6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants