Skip to content

Conversation

@Wodran14
Copy link

No description provided.

pegonzalezspesol and others added 30 commits October 30, 2025 15:44
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
* 'Validation In Progress' so as to allow an easy location of the
   invoices for which a validation has been triggered,
   but it is not yet completed.
* 'Validation Not Started' to locate bills that either require
   no validation, or the request for validation has not yet been initiated.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_move_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/
Currently translated at 100.0% (26 of 26 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
Currently translated at 100.0% (27 of 27 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/sv/
…moves with tier validation

Added tests for changes

Updated error to be checked in tests

Updated error to be checked in tests
Currently translated at 100.0% (28 of 28 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/it/
Edit a new journal entry with lines in currency X different from company currency Y.
Say you have a line of value (amount_currency) N, which is converted to Y(N) (debit/credit).
Then `amount_total` is also N. Because the `readonly="not(review_ids)"` was added, `amount_total` is dirty and sent at save.
Therefore, Odoo uses it and sets the debit/credit values of the lines to N (instead of Y(N), the converted value).
It's as if it's ignoring the currency conversion (note that the values are correct through onchange before the save).

To avoid this, exclude the field from being modified in `get_view`.
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wodran14 Thank you for the migration. It should be nice to temporarily add a test dependency on OCA/server-ux#1176 to allow functional tests with runboat and makes checks for test ✔️ into the CI. Moreover should this addon be moved to the new repo https://github.com/OCA/tier-validation? see OCA/purchase-workflow#2857

@bosd
Copy link
Contributor

bosd commented Jan 10, 2026

superseeded by OCA/tier-validation#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.