Skip to content

Conversation

@MarinaAForgeFlow
Copy link

@MarinaAForgeFlow MarinaAForgeFlow commented Jun 2, 2025

Depends on: #838

@github-actions
Copy link

github-actions bot commented Oct 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 5, 2025
@edescalona
Copy link

Hi @MarinaAForgeFlow , are you going to continue this PR?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 2, 2025
@MarinaAForgeFlow
Copy link
Author

MarinaAForgeFlow commented Nov 3, 2025

Hi @MarinaAForgeFlow , are you going to continue this PR?

Hi @edescalona , what do you mean by continue? I am already using it, just waiting for it to be approved and merged. I need first the dependency tho.

@edescalona
Copy link

Hi @MarinaAForgeFlow , thanks for commenting. Perhaps if you rebase the pull request, the tests will pass and the runboat issue will be fixed, allowing us to push for the merger.

I need to define non-payment days for each client. Do you have any plans for this?

@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 18.0-add-account_payment_term_partner_payment_days branch from 0698a91 to 068556f Compare November 4, 2025 09:13
@MarinaAForgeFlow
Copy link
Author

Hi @MarinaAForgeFlow , thanks for commenting. Perhaps if you rebase the pull request, the tests will pass and the runboat issue will be fixed, allowing us to push for the merger.

I need to define non-payment days for each client. Do you have any plans for this?

@edescalona I do not have plans for non-payment days. Could you explain more which are your needs? I think it shouldn't be difficult to achieve it with the already implemented logic on this PR.

@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 18.0-add-account_payment_term_partner_payment_days branch from 6a98dd2 to 6835224 Compare November 4, 2025 09:38
@edescalona
Copy link

edescalona commented Nov 4, 2025

Hi @MarinaAForgeFlow , basically it involves defining date ranges for which payments cannot be made to client X, and changing the invoice due date accordingly, based on those ranges and the configured payment terms. For example:

Current Date: 11/4/2025
No payment period: 12/3/2025-12/10/2025
Payment Days: 7, 9

When the invoice is confirmed, the due date would be 12/4/2025, which falls within the range above. Therefore, the due date would be changed to 1/7/2026, as that is the first payment term configured.

Do you plan to migrate this PR to 17.0?

Because my idea is to rely on this add-on to use the payment term fields and, through configuration, enable the non-payment term logic.

Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants