-
-
Notifications
You must be signed in to change notification settings - Fork 476
[ADD] account_payment_term_partner_paydays #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[ADD] account_payment_term_partner_paydays #839
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
Hi @MarinaAForgeFlow , are you going to continue this PR? |
Hi @edescalona , what do you mean by continue? I am already using it, just waiting for it to be approved and merged. I need first the dependency tho. |
|
Hi @MarinaAForgeFlow , thanks for commenting. Perhaps if you rebase the pull request, the tests will pass and the runboat issue will be fixed, allowing us to push for the merger. I need to define non-payment days for each client. Do you have any plans for this? |
0698a91 to
068556f
Compare
@edescalona I do not have plans for non-payment days. Could you explain more which are your needs? I think it shouldn't be difficult to achieve it with the already implemented logic on this PR. |
6a98dd2 to
6835224
Compare
|
Hi @MarinaAForgeFlow , basically it involves defining date ranges for which payments cannot be made to client X, and changing the invoice due date accordingly, based on those ranges and the configured payment terms. For example: Current Date: 11/4/2025 When the invoice is confirmed, the due date would be 12/4/2025, which falls within the range above. Therefore, the due date would be changed to 1/7/2026, as that is the first payment term configured. Do you plan to migrate this PR to 17.0? Because my idea is to rely on this add-on to use the payment term fields and, through configuration, enable the non-payment term logic. |
edescalona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on: #838