Skip to content

[18.0][FIX] Payment return import iso20022 match by payment id #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qgroulard wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] Payment return import iso20022 match by payment id #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions account_payment_return_import_iso20022/models/payment_return.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,17 @@ def _find_match(self):
for line in self.filtered(lambda x: not x.move_line_ids and x.reference):
if not line.reference.isdigit():
continue
payments = self.env["account.payment"].search(
payment = self.env["account.payment"].search(
[
("move_id", "=", int(line.reference)),
("id", "=", int(line.reference)),
("payment_order_id", "!=", False),
],
)
if payments:
line.partner_id = payments[0].partner_id
for payment in payments:
line.move_line_ids |= payment.move_id.line_ids.filtered(
lambda x, payment=payment: x.account_id
== payment.destination_account_id
and x.partner_id == payment.partner_id
)
if payment:
line.partner_id = payment.partner_id
line.move_line_ids |= payment.move_id.line_ids.filtered(
lambda x, payment=payment: x.account_id
== payment.destination_account_id
and x.partner_id == payment.partner_id
)
return super()._find_match()