[18.0][FIX] account_payment_return: Select proper outstanding account #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odoo has changed the mechanism of selecting outstanding account: on v17 there were a field "account_journal_payment_debit_account_id" on res.company for holding the outstanding account. Now, this outstanding account is reflected through an XML-ID identifier. Thus, the adaptation to the module should follow the same mechanism for selecting the outstanding account. There's also no need of a specific error message, as the method already contains one. TT58856
Member
Author
|
Linked to OCA/OpenUpgrade#5425 |
carlosdauden
approved these changes
Oct 27, 2025
Member
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at d65b35d. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
18.0-fix-account_payment_return-outstanding_account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odoo has changed the mechanism of selecting outstanding account: on v17 there were a field "account_journal_payment_debit_account_id" on res.company for holding the outstanding account. Now, this outstanding account is reflected through an XML-ID identifier.
Thus, the adaptation to the module should follow the same mechanism for selecting the outstanding account.
There's also no need of a specific error message, as the method already contains one.
@Tecnativa TT58856