[19.0][MIG] product_harmonized_system_delivery: Migration to 19.0 #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizzappdev
force-pushed
the
19.0-mig-product_harmonized_system_delivery-BAD
branch
from
d074812 to
1168949
Compare
bizzappdev
force-pushed
the
19.0-mig-product_harmonized_system_delivery-BAD
branch
from
1168949 to
9f1d7bc
Compare
…e field) Finalize port to v11
This commit is the "followup" of the change to company_dependent=False on the fields hs_code_id on product.template and product.category. Add groupby on hs_code_id on product.template search view hs.code is now company_id=False by default
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: intrastat-extrastat-15.0/intrastat-extrastat-15.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-15-0/intrastat-extrastat-15-0-product_harmonized_system_delivery/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/hr/
Currently translated at 100.0% (3 of 3 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/es/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/es/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/it/
[FIX] change no-stored field [ADD] add contributor
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: intrastat-extrastat-18.0/intrastat-extrastat-18.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-18-0/intrastat-extrastat-18-0-product_harmonized_system_delivery/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-18.0/intrastat-extrastat-18.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-18-0/intrastat-extrastat-18-0-product_harmonized_system_delivery/it/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-18.0/intrastat-extrastat-18.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-18-0/intrastat-extrastat-18-0-product_harmonized_system_delivery/it/
bizzappdev
force-pushed
the
19.0-mig-product_harmonized_system_delivery-BAD
branch
from
9f1d7bc to
7f99fb1
Compare
bizzappdev
force-pushed
the
19.0-mig-product_harmonized_system_delivery-BAD
branch
2 times, most recently
from
5e0c699 to
408d071
Compare
twalter-c2c
approved these changes
Dec 10, 2025
twalter-c2c
left a comment
twalter-c2c
left a comment
There was a problem hiding this comment.
Looks good, thank you for extending the test coverage. Only one small remark - please use the [IMP] tag instead of the [ADD] one for the commit containing additional tests (you can check the relevant guidelines here.
bizzappdev
force-pushed
the
19.0-mig-product_harmonized_system_delivery-BAD
branch
from
408d071 to
6e27c95
Compare
Author
|
@twalter-c2c Changes in commit msg is done. |
twalter-c2c
reviewed
Dec 12, 2025
Comment on lines
13
to
17
| <field name="arch" type="xml"> | ||
| <field name="hs_code" position="attributes"> |
There was a problem hiding this comment.
While checking in the UI, I noticed that there is an orphaned "Traceability" group in the product view. This has been made shown in v19. I suppose that we may want to hide it.
Suggested change
| <field name="arch" type="xml"> | |
| <field name="hs_code" position="attributes"> | |
| <field name="arch" type="xml"> | |
| <xpath expr="//group[@name='traceability']" position="attributes"> | |
| <attribute name="invisible">1</attribute> | |
| </xpath> | |
| <field name="hs_code" position="attributes"> |
Contributor
|
This PR has the |
bizzappdev
force-pushed
the
19.0-mig-product_harmonized_system_delivery-BAD
branch
from
6e27c95 to
b25053f
Compare
|
Thank you for applying the suggestion so quickly. It is all good now, in my opinion, well done! @simahawk I guess we are good to merge this one as well. It would be great if you could do the magic 🙏🏻 |
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at e2dddbf. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency PR for module
product_harmonized_system: #317