-
-
Notifications
You must be signed in to change notification settings - Fork 282
[16.0] l10n br fiscal: Calculo dos novos impostos IBS/CBS e IS #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
renatonlima
wants to merge
7
commits into
OCA:16.0
Choose a base branch
from
akretion:16.0-l10n_br_fiscal-tax-compute-ibs-cbs
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−25
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fee3864
[IMP] l10n_br_fiscal: Added demo data for IBS and CBS
renatonlima 8d6f1ff
[IMP] l10n_br_fiscal: Adapted fiscal document edition and created fis…
renatonlima 9dbf240
[FIX] l10n_br_sale_stock: assertAlmostEqual for Floats
rvalyi 886decb
[IMP] l10n_br_nfe: adapt test for IBS/CBS
rvalyi 926f244
[IMP] l10n_br_account: adapt test for IBS/CBS
rvalyi 90ad108
[FIX] l10n_br_account: force_fiscal_amount_recompute fix
rvalyi 814ce72
[DON'T MERGE] l10n_br_sale_stock: don't break on unbalanced moves
rvalyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aqui realmente é necessario essa alteração ?
o que acontece se deixar só o move._compute_fiscal_amount()?
Obs: esse compute dentro de outro compute sempre me preocupa, por causa das alterações dos campos não protegidos da ORM, é algo bem complexo pra debugar..
Penso que o bug no teste pode ser algo relacionado aqui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pelo jeito o @renatonlima misturou com essa outra mudança #4268 Eh preciso sim. o Uso desse compute no compute é excepcional, mas a gente ja pegou varios casos onde é necessário. (ver no PR#4268 mas teve outros casos reportados tb onde é preciso)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah agora ficou claro, valeu @rvalyi!