-
-
Notifications
You must be signed in to change notification settings - Fork 282
[17.0][l10n_br_base] don't mess with base.main_company country_id; avoid demo conflicts #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @renatonlima, |
7d429bf to
977ffcb
Compare
977ffcb to
f004068
Compare
| <field name="street_number">1</field> | ||
| <field name="district">Bela Vista</field> | ||
| <field name="city_id" ref="l10n_br_base.city_3550308" /> | ||
| <!--field name="city_id" ref="l10n_br_base.city_3550308" /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isso aqui não deveria ser removido?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feito
f004068 to
b5c0ffc
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0482530. Thanks a lot for contributing to OCA. ❤️ |
Mas não é so isso, tambem tive que fazer isso pro port do l10n_br_account para a 17.0 aqui #4339 para evitar erros semelhantes com o modulo account. No PR #4339 eu mudo o main_company para BRL no hook de instalação do modulo account, ou seja mais tarde...
Eu tive que fazer um commit nele para não depender do base.main_company