Skip to content

Conversation

@rvalyi
Copy link
Member

@rvalyi rvalyi commented Jan 11, 2026

  1. desativa o set BRL no main_company de demo no l10n_br_base, pois isso cria problemas. Por exemplo se instalar o l10n_br_base com demo e depois o modulo stock pega erros como:
2026-01-11 14:21:14,975 15474 INFO odoo17 odoo.modules.loading: Module stock: loading demo
2026-01-11 14:21:14,976 15474 INFO odoo17 odoo.modules.loading: loading stock/data/stock_demo_pre.xml
2026-01-11 14:21:15,189 15474 INFO odoo17 odoo.modules.loading: loading stock/data/stock_demo.xml
2026-01-11 14:21:16,176 15474 INFO odoo17 odoo.modules.loading: loading stock/data/stock_demo2.xml
2026-01-11 14:21:16,814 15474 WARNING odoo17 odoo.modules.loading: Module stock demo data failed to install, installed without demo data
Traceback (most recent call last):
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/models.py", line 5896, in ensure_one
    _id, = self._ids
    ^^^^
ValueError: too many values to unpack (expected 1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/tools/convert.py", line 564, in _tag_root
    f(rec)
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/tools/convert.py", line 280, in _tag_function
    _eval_xml(self, rec, env)
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/tools/convert.py", line 205, in _eval_xml
    return odoo.api.call_kw(model, method_name, args, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/api.py", line 484, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/api.py", line 469, in _call_kw_multi
    result = method(recs, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rvalyi/DEV/odoo17/odoo/src/addons/stock/models/stock_picking.py", line 928, in action_confirm
    self.move_ids.filtered(lambda move: move.state == 'draft')._action_confirm()
  File "/home/rvalyi/DEV/odoo17/odoo/src/addons/stock/models/stock_move.py", line 1425, in _action_confirm
    moves = self._merge_moves(merge_into=merge_into)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rvalyi/DEV/odoo17/odoo/src/addons/stock/models/stock_move.py", line 1078, in _merge_moves
    neg_key = self._merge_move_itemgetter(distinct_fields, excluded_fields)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rvalyi/DEV/odoo17/odoo/src/addons/stock/models/stock_move.py", line 1040, in _merge_move_itemgetter
    currency_precision = self.company_id.currency_id.decimal_places
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/fields.py", line 1148, in __get__
    record.ensure_one()
  File "/home/rvalyi/DEV/odoo17/odoo/src/odoo/models.py", line 5899, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: res.currency(5, 1)

Mas não é so isso, tambem tive que fazer isso pro port do l10n_br_account para a 17.0 aqui #4339 para evitar erros semelhantes com o modulo account. No PR #4339 eu mudo o main_company para BRL no hook de instalação do modulo account, ou seja mais tarde...

  1. Tirando o base.main_company to Brasil nos dados de demo o teste seguinte passou a falhar:
2026-01-13_04-27

Eu tive que fazer um commit nele para não depender do base.main_company

  1. Eu tb arrumei o write do res.company para permitir de alterar para BRL ou USD as 3 empresas de demo. Pois na migração do l10n_br_account em [17.0][MIG] l10n_br_account #4339, eu deixo as empresas em USD para poder instalar o generic_coa (se não tiver os modulos l10n_br_simples o l10n_br_generic presentes, por exemplo porque não foram migrados ou instalados (caso l10n_br_account for com instalado com pip) e depois mudo as 3 empresas para BRL no hook do l10n_br_account.

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi rvalyi marked this pull request as draft January 11, 2026 16:48
@rvalyi rvalyi force-pushed the 17.0-fix-base-comp-currency branch from 7d429bf to 977ffcb Compare January 13, 2026 04:23
@rvalyi rvalyi changed the title [17.0][l10n_br_base] fix write currency on demo companies [17.0][l10n_br_base] don't mess with base.main_company country_id; avoid demo conflicts Jan 13, 2026
@rvalyi rvalyi force-pushed the 17.0-fix-base-comp-currency branch from 977ffcb to f004068 Compare January 13, 2026 04:29
@rvalyi rvalyi marked this pull request as ready for review January 13, 2026 04:57
<field name="street_number">1</field>
<field name="district">Bela Vista</field>
<field name="city_id" ref="l10n_br_base.city_3550308" />
<!--field name="city_id" ref="l10n_br_base.city_3550308" /-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isso aqui não deveria ser removido?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feito

@rvalyi
Copy link
Member Author

rvalyi commented Jan 15, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4348-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eb50543 into OCA:17.0 Jan 15, 2026
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0482530. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants