Skip to content

[18.0][MIG] l10n_br_sale - #4459

Merged
OCA-git-bot merged 1070 commits into
OCA:18.0from
akretion:18.0-mig-l10n_br_sale
Jun 19, 2026
Merged

[18.0][MIG] l10n_br_sale#4459
OCA-git-bot merged 1070 commits into
OCA:18.0from
akretion:18.0-mig-l10n_br_sale

Conversation

@rvalyi

@rvalyi rvalyi commented Mar 26, 2026

Copy link
Copy Markdown
Member

migração a partir da migração v17 #4444 ; depende de #4446

@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch 2 times, most recently from 2016775 to 67f5a9a Compare March 26, 2026 11:35
@rvalyi
rvalyi marked this pull request as draft March 26, 2026 11:35
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from 67f5a9a to b1d058c Compare March 29, 2026 14:52
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from b1d058c to 1626f1e Compare April 22, 2026 14:38
@OCA-git-bot OCA-git-bot added mod:l10n_br_coa_generic Module l10n_br_coa_generic series:18.0 mod:l10n_br_sale Module l10n_br_sale labels Apr 22, 2026
@rvalyi

rvalyi commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

a CI ficou vermelha apenas por causa de um warning:

errors that caused failure (4):
2026-04-22 14:42:42,709 914 WARNING odoo odoo.fields: sale.order.line.ind_final: selection attribute will be ignored as the field is related 
2026-04-22 14:42:46,638 914 WARNING odoo odoo.fields: sale.order.line.ind_final: selection attribute will be ignored as the field is related 
2026-04-22 14:42:47,135 914 WARNING odoo odoo.fields: sale.order.line.ind_final: selection attribute will be ignored as the field is related 
2026-04-22 14:42:47,373 914 WARNING odoo odoo.fields: sale.order.line.ind_final: selection attribute will be ignored as the field is related

@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from 1626f1e to e28fc97 Compare May 27, 2026 11:52
@OCA-git-bot OCA-git-bot removed the mod:l10n_br_coa_generic Module l10n_br_coa_generic label May 27, 2026
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from 9601406 to c47ebf4 Compare May 27, 2026 12:33
@OCA-git-bot OCA-git-bot added mod:l10n_br_coa_generic Module l10n_br_coa_generic mod:l10n_br_base_l10n_br_compat Module l10n_br_base_l10n_br_compat labels May 27, 2026
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from f5aaafa to 86e768d Compare May 27, 2026 15:10
@OCA-git-bot OCA-git-bot removed mod:l10n_br_coa_generic Module l10n_br_coa_generic mod:l10n_br_base_l10n_br_compat Module l10n_br_base_l10n_br_compat labels May 27, 2026
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch 2 times, most recently from ebca569 to 84ba332 Compare May 27, 2026 21:55
@OCA-git-bot OCA-git-bot added the mod:l10n_br_stock Module l10n_br_stock label May 27, 2026
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch 5 times, most recently from befb7b9 to 6ab2e3a Compare May 29, 2026 15:04
@rvalyi rvalyi mentioned this pull request Jun 4, 2026
Draft
2 tasks
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from ca3402f to f3cd018 Compare June 18, 2026 19:53
@OCA-git-bot OCA-git-bot added the mod:l10n_br_account Module l10n_br_account label Jun 18, 2026
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch 2 times, most recently from 3dae9ee to eab7459 Compare June 19, 2026 00:08
@rvalyi
rvalyi marked this pull request as ready for review June 19, 2026 00:33
CristianoMafraJunior
CristianoMafraJunior suggested changes Jun 19, 2026
View reviewed changes

@CristianoMafraJunior CristianoMafraJunior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[REVIEW FUNCIONAL]

1 - Acessar módulo vendas
2 - Criar uma cotação
3 - Salvar a cotação
4 - Abrir o Form me apresentou esse erro

image

rvalyi added 7 commits June 19, 2026 10:19
@rvalyi
[MIG] l10n_br_sale: Migration to 18.0
56a0c43
@rvalyi
[FIX] l10n_br_stock: harden demo hook
7cd76db
@rvalyi
[FIX] l10n_br_stock: harden post_init_hook and demo data
13cf13c
@rvalyi
[FIX] l10n_br_sale: make tests independent of demo data
08b05c6 
Follow the same pattern as l10n_br_purchase and other l10n_br modules:

- Create tests/tools.py with load_sale_fixture_files() to load
demo data as test fixtures when needed
- Make L10nBrSaleBaseTest.setUpClass load fixtures conditionally
if demo data is not already present
- This ensures tests pass with or without demo data installed

This approach is compatible with Odoo 18.0 and 19.0.
@rvalyi
[IMP] l10n_br_account: improve l10n_latam_invoice_document compat
29db5b6
@rvalyi
[FIX] l0n_br_sale: adapt discount tests for 18.0
59e6076
@rvalyi
[FIX] l10n_br_sale: avoid ind_final warning
07ad764
@rvalyi
rvalyi force-pushed the 18.0-mig-l10n_br_sale branch from eab7459 to 07ad764 Compare June 19, 2026 13:19
@rvalyi

rvalyi commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

[REVIEW FUNCIONAL]

1 - Acessar módulo vendas 2 - Criar uma cotação 3 - Salvar a cotação 4 - Abrir o Form me apresentou esse erro
image

valeu pelo teste @CristianoMafraJunior
entao, fiz como no modulo l10n_br_account, tirei o botao da ediçao popup (no rebase de agora) porque precisa de um refator mais extenso do Javascript. Por enquanto da para a forçar o popup pelo grupo ou com a chave de contexto.

Se vc tiver interesse, a funcionalidade da ediçao popup eu extrai neste novo modulo do OCA/web:
OCA/web#3522
Se vc quiser ver em açao na localizaçao pode testar aqui akretion#290

Mas eu diria que podemos mesclar sem o botao por enquanto para destravar a migraçao dos outros modulos...

kaynnan
kaynnan approved these changes Jun 19, 2026
View reviewed changes

@kaynnan kaynnan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Por mim, tudo bem mesclar sem essa questão do botão, para prosseguirmos com os demais módulos.

@CristianoMafraJunior

CristianoMafraJunior commented Jun 19, 2026

Copy link
Copy Markdown
Member

[REVIEW FUNCIONAL]
1 - Acessar módulo vendas 2 - Criar uma cotação 3 - Salvar a cotação 4 - Abrir o Form me apresentou esse erro
image

valeu pelo teste @CristianoMafraJunior entao, fiz como no modulo l10n_br_account, tirei o botao da ediçao popup (no rebase de agora) porque precisa de um refator mais extenso do Javascript. Por enquanto da para a forçar o popup pelo grupo ou com a chave de contexto.

Se vc tiver interesse, a funcionalidade da ediçao popup eu extrai neste novo modulo do OCA/web: OCA/web#3522 Se vc quiser ver em açao na localizaçao pode testar aqui akretion#290

Mas eu diria que podemos mesclar sem o botao por enquanto para destravar a migraçao dos outros modulos...

Por mim pode tirar o botão e seguir com a migração

@rvalyi

rvalyi commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Ja tirei o botão no rebase...

@douglascstd

douglascstd commented Jun 19, 2026

Copy link
Copy Markdown
Member

Nao acessa pelo runboat. Não tive sucesso:
image

@rvalyi

rvalyi commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Nao acessa pelo runboat. Não tive sucesso: image

Pode tentar de novo, talvez apagando seus cookies ou com janela anonima, pois acabei de entrar se problema.

CristianoMafraJunior
CristianoMafraJunior approved these changes Jun 19, 2026
View reviewed changes

@CristianoMafraJunior CristianoMafraJunior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[REVIEW FUNCIONAL]
1- Criação de uma cotação
2 - Criação de um pedido de venda
3 - Criação de um pedido de venda até criação da Fatura

Image

@rvalyi

rvalyi commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-4459-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 885a792 into OCA:18.0 Jun 19, 2026
5 of 7 checks passed
@OCA-git-bot

OCA-git-bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9636b1a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kaynnan kaynnan kaynnan approved these changes
@CristianoMafraJunior CristianoMafraJunior CristianoMafraJunior approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:l10n_br_account Module l10n_br_account mod:l10n_br_sale Module l10n_br_sale mod:l10n_br_stock Module l10n_br_stock series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.