Skip to content

[18.0][IMP] l10n_fr_siret_lookup: Conditionally check VIES and force VAT + tests #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
remi-filament wants to merge 13 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][IMP] l10n_fr_siret_lookup: Conditionally check VIES and force VAT + tests #682

remi-filament wants to merge 13 commits into from

Conversation

@remi-filament
Copy link
Contributor

@remi-filament remi-filament commented Sep 23, 2025

As proposed in #680 (comment)

I have added a couple of things on this module :

  1. Add dependency to base_vat (needed for 2. below + base_vat is a dependency of l10n_fr_account and most of localizations so it should be installed anyway if using Invoicing and French localization)
  2. Check VIES server for computed VAT number only if company is configured to check VAT number against VIES (field vat_check_vies from base_vat module)
  3. Add an extra config parameter (company dependant) : force_vat_siret_lookup, allowing to use VAT number computed by this module from SIREN even if VIES check fails (for timeout) or if VIES check is disabled
  4. Add tests for testing the different possible scenarios for all onchange

This is also linked to #591 trying to workaround the MS_MAX_CONCURRENT_REQ raised by VIES service most of the times when checking for FR VAT.

Note that if VIES returns that VAT is invalid, the VAT is emptied in any scenario (independent of value of force_vat_siret_lookup)

We could go a few steps further, for instance by showing the validation status on partner form view and either allowing to rerun the check or to be handled by cron.

@remi-filament
Copy link
Contributor Author

remi-filament commented Sep 23, 2025

Built on top of #681

@remi-filament
Copy link
Contributor Author

remi-filament commented Sep 23, 2025

Hi @alexis-via I would appreciate your feedback on this proposal when you can spare a few minutes !
Thanks

@remi-filament remi-filament force-pushed the 18.0-imp2-l10n_fr_siret_lookup branch 2 times, most recently from 7033cd2 to 6a9ac66 Compare September 23, 2025 16:57
@remi-filament remi-filament force-pushed the 18.0-imp2-l10n_fr_siret_lookup branch 3 times, most recently from cefd8bd to 7fd35fd Compare September 24, 2025 15:28
@remi-filament
Copy link
Contributor Author

remi-filament commented Sep 25, 2025

Thinking again about this module how to request new validation from VIES service, I started another module not directly related to this one, since the issue with max request happens also without this module installed.
See OCA/account-financial-tools#2154

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 29, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@remi-filament remi-filament force-pushed the 18.0-imp2-l10n_fr_siret_lookup branch from 7fd35fd to a9dc971 Compare September 29, 2025 14:07
@flotho
Copy link
Member

flotho commented Dec 10, 2025

Hi @remi-filament , any chance to rebase to trigger CI/CD and go to merge

alexis-via and others added 13 commits December 10, 2025 10:03
@alexis-via @remi-filament
Rename module to l10n_fr_siret_lookup
ad5c4c5 
Rename wizard obj to fr.siret.lookup
Test on stdnum version number
@remi-filament
Translated using Weblate (French)
9a271e0 
Currently translated at 97.7% (43 of 44 strings)

Translation: l10n-france-14.0/l10n-france-14.0-l10n_fr_siret_lookup
Translate-URL: https://translation.odoo-community.org/projects/l10n-france-14-0/l10n-france-14-0-l10n_fr_siret_lookup/fr/
@alexis-via @remi-filament
[FIX] l10n_fr_siret_lookup: zip is now given as int by the API
6a49584 
'codedepartementetablissement' is not always set (in particular for companies in Corsica), so we now only use codepostaletablissement
@OCA-git-bot @remi-filament
l10n_fr_siret_lookup 14.0.1.1.0
e3616a3
@alexis-via @remi-filament
[MIG] l10n_fr_siret_lookup to v16
4aa4729
@Ivorra78 @remi-filament
Added translation using Weblate (Spanish)
b21c08d
@yajo @remi-filament
[FIX] l10n_fr_siret[_lookup]: remove wrong dependency
7ac6173 
Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies.

Besides, [python-stdnum is pinned to 1.16][1]. Thus, when applying OCA/oca-ci#66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream.

[1]: https://github.com/odoo/odoo/blob/fe4d8e8014e50d4335e0a8b052b5098f3a79bcec/requirements.txt#L48

@moduon MT-4520
@remi-filament
[IMP] l10n_fr_siret_lookup: add check for active companies
e2c3f13
@remi-filament
[IMP] l10n_fr_siret_lookup: apply pre-commit auto fixes
71b4843
@remi-filament
[MIG] l10n_fr_siret_lookup: Migration to 17.0
b6fc0e2
@remi-filament
[IMP] l10n_fr_siret_lookup: pre-commit auto fixes
61606d4
@remi-filament
[MIG] l10n_fr_siret_lookup: Migration to 18.0
b8046c1
@remi-filament
[IMP] l10n_fr_siret_lookup: add config params
eadc898
@remi-filament remi-filament force-pushed the 18.0-imp2-l10n_fr_siret_lookup branch from a9dc971 to eadc898 Compare December 10, 2025 09:04
@remi-filament
Copy link
Contributor Author

remi-filament commented Dec 10, 2025

Done @flotho although I am still looking for a replacement regarding your comment here : #680 (review)
We have implemented something similar with INPI RNE API or INSEE SIRENE API but I need to go further into the analysis...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Hugo-Trentesaux Hugo-Trentesaux Hugo-Trentesaux approved these changes

@julienCozo julienCozo julienCozo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@remi-filament @OCA-git-bot @flotho @Hugo-Trentesaux @julienCozo @alexis-via @Ivorra78 @yajo