[17.0][IMP] l10n_fr_siret: decouple fields constraints
#716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @alexis-via, |
SilvioC2C
force-pushed
the
17.0-IMP-l10n_fr_siret
branch
2 times, most recently
from
345de03 to
74e23dc
Compare
SilvioC2C
changed the title
l10n_fr_siret: decouple constraint from inverse methodl10n_fr_siret: decouple fields constraints
- move the check upon partner's ``siret`` to its own ``@api.constrains``-decorated method - refactor constraints to check its specific field (either ``siren`` or ``nic``) - add helper methods to check SIRET, SIREN and NIC validity - lesser refactoring of ``_compute_siret()`` and ``_inverse_siret()``
SilvioC2C
force-pushed
the
17.0-IMP-l10n_fr_siret
branch
from
74e23dc to
6859ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
siretto its own@api.constrains-decorated methodsirenornic)_compute_siret()and_inverse_siret()