[18.0][ADD] hr_expense_meal_allowance: Meal allowance rates for german Verpflegungsmehraufwände #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRogos
force-pushed
the
18.0-add-hr_expense_meal_allowance
branch
from
e180cf0 to
2973767
Compare
|
Nice work. Looks good to me at first testings from a user/functional perspective. Will test more thoroughly once time allows. |
CRogos
force-pushed
the
18.0-add-hr_expense_meal_allowance
branch
from
2973767 to
3eef8c3
Compare
CRogos
changed the title
MohamedOsman7
left a comment
MohamedOsman7
left a comment
There was a problem hiding this comment.
The currency field is not readonly:
Otherwise everthing is working fine.
…flegungsmehraufwände
CRogos
force-pushed
the
18.0-add-hr_expense_meal_allowance
branch
from
3eef8c3 to
dc812cf
Compare
|
LGTM. Rates are working fine. When customers from different countries are chosen, the total and daily switch immediately to the correct rates. Updated rates for 2026 are already in the queue as far as I know and have seen. |
|
Am I doing something wrong or testing the wrong version? There is this currency warning 
|
CRogos
force-pushed
the
18.0-add-hr_expense_meal_allowance
branch
from
ba8ffe8 to
fc9a671
Compare
Contributor
Author
|
@smaddlsoft I agree that this error should not happen, but I am struggling how to fix it? As soon as you fill out the travel information, the currency will be filled and saving is possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally... as discussed at the Odoo Exp, I've finished the improvements on the module and now make it available to the OCA.
@ng-ife, @ho-ife maybe you would like to have a look here.