[18.0][ADD] l10n_jp_summary_invoice_carryover #102
Conversation
yostashiro
force-pushed
the
18.0-add-l10n_jp_summary_invoice_carryover
branch
3 times, most recently
from
736da93 to
5b4e35f
Compare
|
In terms of the report presentation, highlighted parts are added/adjusted by this module. |
|
|
||
| class TestSummaryInvoiceCarryover(TransactionCase): | ||
| @classmethod | ||
| def setUpClass(cls): |
There was a problem hiding this comment.
@AungKoKoLin1997 We can reuse the setup of l10n_jp_summary_invoice if we refactor the code there. It's not a must-do now, but we want to work on it at some point.
yostashiro
force-pushed
the
18.0-add-l10n_jp_summary_invoice_carryover
branch
from
5b4e35f to
ca0bba9
Compare
| rec.prev_billed_amount_manual | ||
| if rec.use_prev_billed_amount_manual | ||
| else rec.prev_billed_amount |
There was a problem hiding this comment.
A little helper method would be nice, so it can be used here and also in the report template.
| rec.payment_amount_manual | ||
| if rec.use_payment_amount_manual | ||
| else rec.payment_amount |
There was a problem hiding this comment.
Same as above, but I'm not sure there should be a shared method or two separate ones.
There was a problem hiding this comment.
I decided to use two separate methods to keep simple.
AungKoKoLin1997
force-pushed
the
18.0-add-l10n_jp_summary_invoice_carryover
branch
from
62b8d2d to
eb1adab
Compare
AungKoKoLin1997
force-pushed
the
18.0-add-l10n_jp_summary_invoice_carryover
branch
from
eb1adab to
98e5824
Compare
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
There was a problem hiding this comment.
Code and functional Test: LGTM
| compute="_compute_prev_billing_candidate_ids", | ||
| ) | ||
| use_prev_billed_amount_manual = fields.Boolean( | ||
| string="Use Manual Previous Billed Amount", |
There was a problem hiding this comment.
| string="Use Manual Previous Billed Amount", | |
| string="Use Manual Previous Billed Amount", | |
| default=False, |
I think manual entry should have default=False.
There was a problem hiding this comment.
The default value of boolean field is False, no?
I don't think we need to use default attribute.
There was a problem hiding this comment.
I seem to have misunderstood a little.
But when I validate the billing record, this boolean field will be True.
Could you check this behabior?
There was a problem hiding this comment.
@kanda999 That is intentional to "lock" the amounts. Otherwise the amounts (especially the payment amount) will show different figures when PDF is printed later. You may suggest an update to the readme. ;)
| help="Total billed amount from the previous billing.", | ||
| ) | ||
| use_payment_amount_manual = fields.Boolean( | ||
| string="Use Manual Payment Amount", |
There was a problem hiding this comment.
| string="Use Manual Payment Amount", | |
| string="Use Manual Payment Amount", | |
| default=False, |
3 participants
This module extends Japan Summary Invoice to support carryover amount tracking
for recurring billing cycles.
It adds the following fields to billings:
Manual override fields are available to adjust values when needed.
The visibility of carryover amounts in the report can be controlled at
company, partner, and billing levels.
Depends on #63
@qrtl QT6214