Skip to content

[IMP] readme model updated with oca img banner #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dora-jurcevic wants to merge 2 commits into from
Closed

[IMP] readme model updated with oca img banner #642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df014f
[IMP] readme model updated with oca img banner
dora-jurcevic Feb 6, 2025
887d039
[FIX] banner size fixed and link modified
dora-jurcevic Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tools/gen_addon_readme.rst.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@
{% endif %}
{%- endmacro -%}

=======
.. image:: https://odoo-community.org/web/image/4610395-7254fada/OCA_banner_readme_1256x150px.png
Copy link
Member

@sbidoul sbidoul May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a nice stable URL here and set up a redirect on the website? In case our website changes we would not want to break existing READMEs.

Copy link
Author

@dora-jurcevic dora-jurcevic May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sbidoul !
This URL was created when we uploaded the image png on the current OCA Website.
In order to have a stable URL for this image I suppose that we would need a module on the current Odoo ERP that creates a route with for example https://odoo-community.org/oca-readme-banner.png ?
Or is there a more simple way of adding a media on a specific URL in Odoo V14?
Thx !

:target: https://odoo-community.org/get-involved?ref=k8vx13&utm_source=referral-readme&utm_medium=referral
Copy link
Member

@sbidoul sbidoul May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "ref=k8vx13" ? Also here should we not use a stable URL in case the details of our website change in the future?

Copy link
Author

@dora-jurcevic dora-jurcevic May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbidoul , here the base URL will be stable https://odoo-community.org/get-involved and we should update each year the referal part of the URL (?ref=k8vx13&utm_source=referral-readme&utm_medium=referral) in the readme repo. If this is not possible (updating the maintainer-tools each year), we should see with @vdewulf to drop the referal part of the url and keep only the base part of the url. This referal part is used for tracking info about the visits on the /get-involved page, to be sure that the visit comes from the readme banner.
@sbidoul, do you think we should avoid updating URL each year ?

:alt: Odoo Community Association

=======

{{ '=' * manifest.name|length }}
{{ manifest.name }}
{{ '=' * manifest.name|length }}
Expand Down
Loading