[18.0][MIG] mrp_subcontracting_skip_no_negative: Migration to 18.0

[AungKoKoLin1997]

@qrtl QT6162

[AungKoKoLin1997]

I found that the commit introduced during the 17.0 migration (#1454 (comment)) not only affects partial subcontracting receipts, but also skips the check from that PR (#1372) when the component quantity is insufficient. Therefore, in my latest commit, I decided to remove the code I originally added in my first PR (#1025), since it is not related to the no negative stock module and the scenario that motivated it no longer occurs in Odoo 18 (#1025 (comment)).

[kanda999]

Functional review: It works as expected in my local env

[yostashiro]

@AungKoKoLin1997 Would you consider adding a test where subcontracting picking receipt fails when component stock is insufficient?

[AungKoKoLin1997]

In my last commit, I bring back the fix from odoo 16 that was not included in17.0 migration and improve tests.
19343f6

I believe my latest two commit should be back ported to 17.0.

[yostashiro]

Code review. LGTM.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[AungKoKoLin1997]

@victoralmau @fdesmottes @Raul-S73
Please let me know if you have a different opinion on the comment above.
#1674 (comment)

[fdesmottes]

@victoralmau @fdesmottes @Raul-S73 Please let me know if you have a different opinion on the comment above. #1674 (commentaire)

Hi @AungKoKoLin1997 it's ok for me.

[victoralmau]

Code review OK

Can you merge the extra commits into the migration commit?

[victoralmau]

Suggested change

	from odoo.tests import Form, TransactionCase
	from odoo.tools import mute_logger
	class TestMrpSubcontractingSkipNoNegative(TransactionCase):
	from odoo.addons.base.tests.common import BaseCommon
	from odoo.tools import mute_logger
	class TestMrpSubcontractingSkipNoNegative(BaseCommon):

[AungKoKoLin1997]

My understanding is that BaseCommon is an internal helper built on top of TransactionCase, mainly used to standardize core tests (such as a mail-disabled context and common user/company setup).
Since our test doesn’t rely on those features, I prefer using TransactionCase to keep it simpler and more explicit.

[pedrobaeza]

The suggestion is for speeding up tests. When you create a record, some chatter messages are added, some followers are auto-added, etc. Using this class, all that things are disabled by default. It's true there's a little overhead with the creation of some users, but it usually worths. Alternatively, you can do cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)).

[AungKoKoLin1997]

@pedrobaeza Thank you for the explanation.
I applied cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) in the tests.

[victoralmau]

Sorry, it's not just those context values, it's more https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/tests/common.py#L11. That's why we always suggest using that BaseCommon class.

[AungKoKoLin1997]

I used BaseCommon class.

[AungKoKoLin1997]

Can you merge the extra commits into the migration commit?

@victoralmau
I want to keep them as separate commits because I plan to backport these commits to 17.0 later. Also, the last commit already exists as a separate commit in Odoo 16.
#1674 (comment)