Skip to content

Simplify installation of oca-gen-addon-icon #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbidoul merged 1 commit into from
Jan 31, 2025
Merged

Simplify installation of oca-gen-addon-icon #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ RUN set -x \
# The main branch bot needs several other command line tools from in OCA/maintainer-tools
# we install them in a separate virtualenv to avoid polluting our main environment.

# Install a specific version of icon generator, to ensure stability as any tiny change
# in generated output may create many commits on all addons.
RUN set -x \
&& python${PY} -m venv /ocamt-pinned \
&& /ocamt-pinned/bin/pip install --no-cache-dir -U pip wheel
RUN set -x \
&& /ocamt-pinned/bin/pip install --no-cache-dir -e git+https://github.com/OCA/maintainer-tools@969238e47c07d0c40573acff81d170f63245d738#egg=oca-maintainers-tools \
&& ln -s /ocamt-pinned/bin/oca-gen-addon-icon /usr/local/bin/

# Other oca maintainer tools that are less sensitive to changes. The README generator is
# not as sensitive as before because it now stores a hash of the fragments in the
# generated README.rst, so it will only regenerate if the fragments have changed.
Expand All @@ -42,6 +33,7 @@ RUN set -x \
&& /ocamt/bin/pip install --no-cache-dir -e git+https://github.com/OCA/maintainer-tools@fbdc8945feabe1f6f3091c1b2d517b6c4160bc2b#egg=oca-maintainers-tools \
&& ln -s /ocamt/bin/oca-gen-addons-table /usr/local/bin/ \
&& ln -s /ocamt/bin/oca-gen-addon-readme /usr/local/bin/ \
&& ln -s /ocamt/bin/oca-gen-addon-icon /usr/local/bin/ \
&& ln -s /ocamt/bin/oca-gen-metapackage /usr/local/bin/ \
&& ln -s /ocamt/bin/oca-towncrier /usr/local/bin/ \
&& ln -s /ocamt/bin/setuptools-odoo-make-default /usr/local/bin/ \
Expand Down