Skip to content

Conversation

@atgalvez08
Copy link

@atgalvez08 atgalvez08 commented Jan 5, 2026

@BinhexTeam
This PR migrates project_tag_hierarchy to Odoo 17.0.

Fixes #1191

@atgalvez08 atgalvez08 force-pushed the 17.0-MIG-project_tag_hierarchy branch from 27fe050 to f1651e9 Compare January 5, 2026 11:07
@atgalvez08 atgalvez08 force-pushed the 17.0-MIG-project_tag_hierarchy branch from df7c6e0 to 0a28df0 Compare January 5, 2026 11:16
@atgalvez08 atgalvez08 marked this pull request as ready for review January 5, 2026 11:20
@rrebollo
Copy link

rrebollo commented Jan 5, 2026

@atgalvez08 Always remember to link the corresponding issue (#1191) to inform others that you're handling this migration.

Typically, migrations consist of two commits:

  1. Pre-commit fixes (before migrating to the target version)
  2. The migration itself

Sometimes only one commit is needed. Also, are you familiar with https://github.com/OCA/oca-port? I recommend checking out OCA's YouTube playlists for helpful videos about this tool.

@rrebollo
Copy link

rrebollo commented Jan 5, 2026

@atgalvez08 Please review the standard contribution procedure. Based on the PR title, this appears to be a migration, but the commit history hasn't been preserved according to OCA conventions.

Refer to the migration guide here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0. The wiki contains specific pages for each version migration.

@rrebollo
Copy link

rrebollo commented Jan 5, 2026

Please address my comments and ping me when it's ready. I would be glad to review it.

@rrebollo
Copy link

rrebollo commented Jan 5, 2026

You need to review the general procedure to contribute. From the title of the PR I'm assuming it's a migration but you didn't preserve commit history according to OCA conventions. Check out https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0. In that wiki there is one page for each version migration.

@atgalvez08 atgalvez08 marked this pull request as draft January 8, 2026 10:59
@atgalvez08
Copy link
Author

This PR has been superseded by #1648, which redoes the migration using oca-port to preserve commit history.

@atgalvez08 atgalvez08 closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants