Skip to content

Conversation

@apami0111
Copy link
Contributor

@apami0111 apami0111 commented Dec 7, 2025

Migration of purchase_allowed_product to Odoo 19.0.
Updated _search method to the new API, adapted views to v19 changes, refreshed tests, and updated module metadata. No functional changes.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you fix the pre-commit, and do you have any idea what's going on with the test job? Maybe try a rebase?

@StefanRijnhart
Copy link
Member

/ocabot migration purchase_allowed_product

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Dec 8, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 8, 2025
76 tasks
@StefanRijnhart
Copy link
Member

Oh, it's the dependency on base_view_inheritance_extension. Is there an open PR for the migration of this module to 19.0?

@apami0111 apami0111 force-pushed the 19.0-mig-purchase_allowed_product branch 2 times, most recently from b107b1e to 41de05f Compare December 17, 2025 01:38
mourad-ehm and others added 23 commits December 16, 2025 20:41
OCA Transbot updated translations from Transifex
[UPD] Update purchase_allowed_product.pot
Currently translated at 46.2% (6 of 13 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_allowed_product/sl/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_allowed_product/
Currently translated at 84.6% (11 of 13 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_allowed_product/fr/
Currently translated at 92.3% (12 of 13 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_allowed_product/fr/
Currently translated at 40.0% (6 of 15 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_allowed_product/pt_BR/
Currently translated at 40.0% (6 of 15 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_allowed_product/pt/
[UPD] Update purchase_allowed_product.pot

[UPD] README.rst
Currently translated at 100.0% (15 of 15 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_allowed_product/zh_CN/
Currently translated at 100.0% (15 of 15 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_allowed_product/fr/
Currently translated at 40.0% (6 of 15 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_allowed_product/pt_BR/
Currently translated at 33.3% (5 of 15 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_allowed_product/it/
Currently translated at 100.0% (15 of 15 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_allowed_product/it/
Currently translated at 93.3% (14 of 15 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_allowed_product/hr/
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_allowed_product/pt_BR/
Ivorra78 and others added 11 commits December 16, 2025 20:41
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_allowed_product/es/
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_allowed_product/es/
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_allowed_product
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_allowed_product/it/
- Make use_only_supplied_product field computed, stored and not readonly
- Propagation of use_only_supplied_product field to invoices
You always can add products to purchase order, so makes sense to be able to see the check/switch always
[IMP] purchase_allowed_product: pre-commit auto fixes
@apami0111
Copy link
Contributor Author

Oh, it's the dependency on base_view_inheritance_extension. Is there an open PR for the migration of this module to 19.0?

Yes, the issue was the dependency on base_view_inheritance_extension. There is an open PR for its migration to 19.0, and I’ve added a temporary reference to it via test-requirements.txt, following OCA guidelines.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart
Copy link
Member

base_view_inheritance_extension is merged now, please remove the test dependency.

@apami0111 apami0111 force-pushed the 19.0-mig-purchase_allowed_product branch from 41de05f to ea36513 Compare December 19, 2025 02:58
@apami0111
Copy link
Contributor Author

base_view_inheritance_extension is merged now, please remove the test dependency.

Thanks, @StefanRijnhart I’ve removed the temporary test dependency now that base_view_inheritance_extension is merged.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-2906-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d6a2913 into OCA:19.0 Dec 22, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dac1506. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.