Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] queue_job: perform_enqueued_jobs should filter the context #738

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] queue_job: perform_enqueued_jobs should filter the context #738

wants to merge 1 commit into from

Conversation

florentx
Copy link
Contributor

@florentx florentx commented Jan 17, 2025 •
edited
Loading

This enhancement is needed to write more accurate tests when the delayed method is context-sensitive.

We had a bug not identified during tests because of this :(

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx florentx changed the title [14.0][IMP] queue_jobs: perform_enqueued_jobs should filter the context [14.0][IMP] queue_job: perform_enqueued_jobs should filter the context Jan 17, 2025
@florentx florentx mentioned this pull request Jan 24, 2025
Merged
@florentx florentx force-pushed the 14.0_trap_context branch 2 times, most recently from a2d94e3 to dd8c852 Compare January 24, 2025 19:13
StefanRijnhart
StefanRijnhart previously approved these changes Feb 5, 2025
View reviewed changes
@StefanRijnhart StefanRijnhart dismissed their stale review March 19, 2025 19:28

Dismissing my review as per other reviewer's comment.

@florentx florentx force-pushed the 14.0_trap_context branch from dd8c852 to 2ed0c75 Compare March 20, 2025 10:21
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@petrus-v petrus-v petrus-v approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florentx @OCA-git-bot @StefanRijnhart @petrus-v