[18.0][PORT] queue_job: remove dead jobs requeuer cron and automatically requeue dead jobs #749
+333
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guewen, |
…eue jobs in timeout [IMP] queue_job: increment 'retry' when re-queuing job that have been killed
A model is better than a manually managed table as it will protect the table from deletion by database_cleanup.
|
@sbidoul looks like you have to rewrite this to use savepoints? |
|
I'm note sure it's possible to test that with savepoints, since we test database locks. |
sbidoul
commented
Mar 21, 2025
| self.assertEqual(1, len(locks)) | ||
|
|
||
| # commit to update queue_job records in DB | ||
| self.env.cr.commit() # pylint: disable=E8102 |
There was a problem hiding this comment.
@AnizR in this test, is it necessary to commit?
There was a problem hiding this comment.
Yes, otherwise, the row representing a 'lock' will not be created within the db
sbidoul
commented
Mar 21, 2025
| job_obj.set_started() | ||
|
|
||
| job_obj.store() | ||
| self.env.cr.commit() # pylint: disable=E8102 |
There was a problem hiding this comment.
Here we could maybe create a job with demo data, and run this test post install.
There was a problem hiding this comment.
Using data to create some records within the db might be a way to avoid to commit within tests, I'll think about it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW port of #748