Skip to content

Conversation

@simahawk
Copy link
Contributor

@simahawk simahawk commented Sep 18, 2025

@simahawk simahawk changed the title Add branch 19.0 on some repos (no defaults) Add branch 19.0 on all repos (no defaults) Sep 18, 2025
@NL66278
Copy link

NL66278 commented Sep 23, 2025

What more is needed? Awaiting existence of 19.0 branch in partner-contact to be able to migrate partner_multi_relation.

@simahawk
Copy link
Contributor Author

I guess we have to solve this 1st OCA/oca-ci#111

@yvaucher
Copy link
Member

@simahawk Was there a reason to have this PR as draft?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Sep 24, 2025

I'd like to have a solution for OCA/oca-addons-repo-template#316 because that one will quickly become annoying, so if we can have it fixed before rolling out 19, that will save me one mass update afterwards.

@simahawk
Copy link
Contributor Author

I've rebased. As long as OCA/oca-addons-repo-template#317 it's merged, we can merge here.

@simahawk simahawk marked this pull request as ready for review September 30, 2025 07:14
@bizzappdev
Copy link

@simahawk OCA/oca-addons-repo-template#317 merged

@bizzappdev
Copy link

I'm not sure how it works, but we also have to ensure that proper pre-commit files are updated with new changes on the server-tools and connector repo, which already have 19.0 branches.

@sbidoul
Copy link
Member

sbidoul commented Sep 30, 2025

I'm not sure how it works, but we also have to ensure that proper pre-commit files are updated with new changes on the server-tools and connector repo, which already have 19.0 branches.

At this point, the easiest is to run copier update --trust -f and do a PR like this one: OCA/mis-builder#735

@simahawk simahawk merged commit 43d7af1 into OCA:master Sep 30, 2025
1 check passed
@bizzappdev
Copy link

There was one mistake on our side. We removed the pre-commit check warning message from mandatory files. But there is also an additional check mentioned in the pylint optional file. Which we have fixed at OCA/oca-addons-repo-template#319
cc @simahawk @sbidoul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants