-
-
Notifications
You must be signed in to change notification settings - Fork 865
[16.0][ADD] report_qweb_decimal_place #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
I think we should treat this PR as an addition instead of migration. |
ea673b6 to
08e1ad2
Compare
| <span | ||
| class="text-nowrap" | ||
| t-esc="price_unit" | ||
| t-options='{"widget": "float", "precision": currency.price_decimal_places}' | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <span | |
| class="text-nowrap" | |
| t-esc="price_unit" | |
| t-options='{"widget": "float", "precision": currency.price_decimal_places}' | |
| /> | |
| <t t-if="currency.apply_price_decimal_place"> | |
| <span | |
| class="text-nowrap" | |
| t-esc="price_unit" | |
| t-options='{"widget": "float", "precision": currency.price_decimal_places}' | |
| /> | |
| </t> |
As we talked earlier, to minimize the code in the extension of individual reports.
| <t t-if="doc.currency_id.apply_price_decimal_place"> | ||
| <t t-set="currency" t-value="doc.currency_id" /> | ||
| <t t-set="price_unit" t-value="line.price_unit" /> | ||
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | ||
| </t> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <t t-if="doc.currency_id.apply_price_decimal_place"> | |
| <t t-set="currency" t-value="doc.currency_id" /> | |
| <t t-set="price_unit" t-value="line.price_unit" /> | |
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | |
| </t> | |
| <t t-set="currency" t-value="doc.currency_id" /> | |
| <t t-set="price_unit" t-value="line.price_unit" /> | |
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> |
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6bb70df to
b15ee48
Compare
b15ee48 to
17e1522
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 8eb7d33. Thanks a lot for contributing to OCA. ❤️ |
@qrtl