[19.0][MIG] sale_product_set: Migration to 19.0 #3941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when a set is added to a sales order, it passes the unit of measure of the product to the sales order line. Fixes an incompatibility with module sale_margin.
…#543) * [imp] move SO `add set` button to smartbutton header * [fix] sale_product_set: PEP8
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_product_set/es/
Co-Authored-By: sbejaoui <[email protected]>
Currently translated at 100.0% (24 of 24 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_product_set/es/
Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_product_set/de/
Currently translated at 100.0% (27 of 27 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_product_set/zh_CN/
Add `partner_id` to product.set allowing to define specific sets per customer
Before this change: try to delete a set used in a wizard right after -> KABOOM! The FK over the set would prevent deletion
[UPD] Update sale_product_set.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Translated using Weblate (Spanish) Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/ [UPD] README.rst
Translated using Weblate (Italian) Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/ [UPD] Update sale_product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/ Translated using Weblate (Spanish) Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/
… product_set The reason to move this logic is that there are other modules that extend product_set as for example stock_product_set but at the same time make use of the transient model to define a wizard. For this reason it is better to have the logic available in product_set module and avoid duplicating code or inheriting from sale_product_set and what this implies in their respective dependencies with the only need to extend the transient model. In addition, the transient model is renamed to make it clearer to identify that it is this type of model. TT48100 [UPD] Update sale_product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/
Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/de/
Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/sv/
Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/it/
[MIG] sale_product_set: add migration to 18.0 for syncing product set state
Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_product_set/tr/
Contributor
|
/ocabot migration sale_product_set |
Contributor
|
@mmrondon Thanks for this. Could you put in this' description the libnk to the depending PR (product_set)? Moreover, you can embed it too here in order to test it thourgh runboat and make tests running following https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 |
Contributor
Author
|
Dependency PR: OCA/product-attribute#2098 |
Contributor
|
An idea is to no more use odoo-test-helper but I'm not sure we can remove it yet. See: OCA/server-tools#3417 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.