Skip to content

[19.0][MIG] module_change_auto_install: Migration to 19.0 #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 36 commits into from
Jan 4, 2026
Merged

[19.0][MIG] module_change_auto_install: Migration to 19.0 #3384

OCA-git-bot merged 36 commits into from
Jan 4, 2026
+1,144 −0

Conversation

@rven
Copy link
Contributor

@rven rven commented Sep 22, 2025

No description provided.

legalsylvain and others added 30 commits September 22, 2025 13:49
@legalsylvain @rven
[ADD] new module module_change_auto_install to configure auto install…
3393126 
…able modules by configuration
@oca-travis @rven
[UPD] Update module_change_auto_install.pot
7a41943
@OCA-git-bot @rven
[UPD] README.rst
1814950
@OCA-git-bot @rven
[ADD] icon.png
45c9abb
@moylop260 @rven
[FIX] module_change_auto_install: Split string sep by comma
969999b 
Optimize validation
Add logger to apply patch
@OCA-git-bot @rven
module_change_auto_install 14.0.1.0.2
323ca86
@legalsylvain @rven
[FIX] module_change_auto_install : auto_install is now a set of depen…
3fbb005 
…dencies. (before, was boolean)
@OCA-git-bot @rven
module_change_auto_install 14.0.1.0.3
ea7668d
@ofonseca-pyming @rven
Added translation using Weblate (Catalan)
9fcfcd6
@kafai-lam @rven
[MIG] module_change_auto_install: Migration to 15.0
7151c48
@legalsylvain @rven
[PORT] module_change_auto_install from 15.0 to 16.0
96b9b41
@rven
[UPD] Update module_change_auto_install.pot
7a2c4e5
@OCA-git-bot @rven
[UPD] README.rst
91eb0fa
@weblate @rven
Update translation files
d13e74c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-module_change_auto_install
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_change_auto_install/
@OCA-git-bot @rven
[UPD] README.rst
3381637
@rven
[IMP] module_change_auto_install: pre-commit stuff
2bacede
@rven
[MIG] module_change_auto_install: Migration to 17.0
491e4ad
@rven
[UPD] Update module_change_auto_install.pot
19d63fa
@OCA-git-bot @rven
[BOT] post-merge updates
18e053c
@lef-adhoc @rven
[MIG] base_exception: Migration to 17.0
9f88a5c
@mymage @rven
Added translation using Weblate (Italian)
640a52a
@pedrobaeza @rven
[FIX] *: Pre-commit fixes
b9311ee
@OCA-git-bot @rven
[BOT] post-merge updates
67a2ed6
@vincent-hatakeyama @rven
[IMP] module_change_auto_install: also allow using environment variables
35a7de6
@OCA-git-bot @rven
[BOT] post-merge updates
e6c2f2a
@lembregtse @rven
[IMP] module_change_auto_install: pre-commit stuff
4eb682f
@lembregtse @rven
[MIG] module_change_auto_install: Migration to 18.0
e707a76
@rven
[UPD] Update module_change_auto_install.pot
23d0773
@OCA-git-bot @rven
[BOT] post-merge updates
26ddb64
@jeroenev @rven
Fix patch message
e06a17c
@rven rven marked this pull request as draft September 25, 2025 10:29
@rven
Copy link
Contributor Author

rven commented Sep 25, 2025

I'm still testing this change, doesn't seem to work right now

@rven rven force-pushed the 19.0-mig-module_change_auto_install branch from 6c05335 to 3522918 Compare September 25, 2025 12:55
@rven
Copy link
Contributor Author

rven commented Sep 25, 2025

It seems to be important to return False iso set() :-)

@rven rven marked this pull request as ready for review September 25, 2025 13:04
@rven rven requested a review from legalsylvain September 25, 2025 13:04
@rven
Copy link
Contributor Author

rven commented Sep 26, 2025

When adding the configuration to the odoo's config file, this warning is shown

2025-09-25 14:44:14,513 556 WARNING ? odoo.tools.config: unknown option 'modules_auto_install_disabled' in the config file at /root/.odoorc, option stored as-is, without parsing

Anybody who knows how we could fix this?

@legalsylvain
Copy link
Contributor

legalsylvain commented Sep 26, 2025

It looks like the spirit of Odoo V19, is to have a fixed quantity of option in the [options] section, defined in the core code.

Could you try to replace :

[options]
server_wide_modules = web,module_change_auto_install

modules_auto_install_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_auto_install_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

by

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

@rven
Copy link
Contributor Author

rven commented Sep 29, 2025

It looks like the spirit of Odoo V19, is to have a fixed quantity of option in the [options] section, defined in the core code.

Could you try to replace :

[options]
server_wide_modules = web,module_change_auto_install

modules_auto_install_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_auto_install_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

by

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

I tried several ways, but the warning pops up too soon.
Odoo refatcored it completly to show a warning on non standard options.

@legalsylvain
Copy link
Contributor

legalsylvain commented Sep 29, 2025

I tried several ways, but the warning pops up too soon.

Could you update the logs ?

We can wait and take a look on this similar OCA modules that will have the same problems :

@rven
Copy link
Contributor Author

rven commented Sep 29, 2025

What do you mean with

Could you update the logs ?

@legalsylvain
Copy link
Contributor

legalsylvain commented Sep 29, 2025

What do you mean with

Could you update the logs ?

Could you put the new log, when you use [module_change_auto_install] in the odoo.cfg file ?

thanks !

@rven rven force-pushed the 19.0-mig-module_change_auto_install branch 2 times, most recently from fe2b3c5 to 086cfb3 Compare September 30, 2025 06:31
@rven
Copy link
Contributor Author

rven commented Sep 30, 2025

@legalsylvain I've managed to use the following config as you mentioned

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

Can you have a look?

@rven rven mentioned this pull request Sep 30, 2025
Open
40 tasks
@rven rven force-pushed the 19.0-mig-module_change_auto_install branch from 086cfb3 to 494a9b7 Compare October 13, 2025 09:08
@rven
Copy link
Contributor Author

rven commented Oct 13, 2025 •
edited
Loading

Changes implemented after this commit of Odoo odoo/odoo@2b4b30c

OCB has not yet the latest version of Odoo.

legalsylvain
legalsylvain approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick overview. LGTM. code review / no test.

StefanRijnhart
StefanRijnhart approved these changes Jan 4, 2026
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Functional test.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 4, 2026

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3384-by-StefanRijnhart-bump-nobump, awaiting test results.

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Jan 4, 2026

/ocabot migration module_change_auto_install

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jan 4, 2026
@OCA-git-bot OCA-git-bot merged commit 89f3790 into OCA:19.0 Jan 4, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 4, 2026

Congratulations, your PR was merged at f839547. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.