-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[19.0][MIG] base_technical_user: Migration to 19.0 #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.0][MIG] base_technical_user: Migration to 19.0 #3385
Conversation
45b746a to
9f4973e
Compare
9f4973e to
ae7297a
Compare
sergijPf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor remarks, the rest seems ok.
tests are green, coverage 100%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these CREDITS seems to be non relevant to 19.0 migration
| </div> | ||
| <div class="section" id="other-credits"> | ||
| <h3><a class="toc-backref" href="#toc-entry-6">Other credits</a></h3> | ||
| <p>The migration of this module from 17.0 to 18.0 was financially supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same here, non relevant to 19.0
[CHG] add name to wml tag to make override easier [FIX] remove domain on active field
OCA Transbot updated translations from Transifex
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-12.0/server-tools-12.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/pt/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-12.0/server-tools-12.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_technical_user/
Currently translated at 85.7% (6 of 7 strings) Translation: server-tools-14.0/server-tools-14.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/
Currently translated at 54.5% (6 of 11 strings) Translation: server-tools-14.0/server-tools-14.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-17.0/server-tools-17.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/
Currently translated at 100.0% (7 of 7 strings) Translation: server-tools-17.0/server-tools-17.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/zh_CN/
First, the company should be taken through self.env.company as user.company_id is now the default company for the user (and not the current one). Secondly, the actual code does not allow to do recordset.with_company(B).sudo_tech().... as allowed_company_ids in context can be filled in with current company (and not the one of the tech user - which is unique)
When we use use_tech(raise_if_missing=True) and the technical user (user_tech_id) is not defined on the current company, the error message who said that field is empty should be related to the active company and not related to the default user's company.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-base_technical_user Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_technical_user/
ae7297a to
510c613
Compare
|
This PR has the |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
|
This PR looks fantastic, let's merge it! |
|
/ocabot migration base_technical_user |
|
Congratulations, your PR was merged at 1718574. Thanks a lot for contributing to OCA. ❤️ |
No description provided.