Skip to content

Conversation

@bizzappdev
Copy link
Contributor

No description provided.

@bizzappdev bizzappdev force-pushed the 19.0-mig-base_technical_user-BAD branch from 45b746a to 9f4973e Compare September 24, 2025 07:55
@bizzappdev bizzappdev marked this pull request as ready for review September 24, 2025 09:32
@bizzappdev bizzappdev force-pushed the 19.0-mig-base_technical_user-BAD branch from 9f4973e to ae7297a Compare October 3, 2025 13:08
Copy link

@sergijPf sergijPf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor remarks, the rest seems ok.
tests are green, coverage 100%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these CREDITS seems to be non relevant to 19.0 migration

</div>
<div class="section" id="other-credits">
<h3><a class="toc-backref" href="#toc-entry-6">Other credits</a></h3>
<p>The migration of this module from 17.0 to 18.0 was financially supported

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here, non relevant to 19.0

Cédric Pigeon and others added 24 commits December 18, 2025 11:49
[CHG] add name to wml tag to make override easier

[FIX] remove domain on active field
OCA Transbot updated translations from Transifex
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/pt/
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-13.0/server-tools-13.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_technical_user/
Currently translated at 85.7% (6 of 7 strings)

Translation: server-tools-14.0/server-tools-14.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-14.0/server-tools-14.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/
Currently translated at 54.5% (6 of 11 strings)

Translation: server-tools-14.0/server-tools-14.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
john-herholz-dt and others added 17 commits December 18, 2025 11:49
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-17.0/server-tools-17.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/zh_CN/
First, the company should be taken through self.env.company as user.company_id
is now the default company for the user (and not the current one).

Secondly, the actual code does not allow to do recordset.with_company(B).sudo_tech()....
as allowed_company_ids in context can be filled in with current company
(and not the one of the tech user - which is unique)
When we use use_tech(raise_if_missing=True) and the technical user (user_tech_id) is not defined on the current company, the error message who said that field is empty should be related to the active company and not related to the default user's company.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-18.0/server-tools-18.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-18.0/server-tools-18.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_technical_user/
@bizzappdev bizzappdev force-pushed the 19.0-mig-base_technical_user-BAD branch from ae7297a to 510c613 Compare December 18, 2025 06:22
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3385-by-etobella-bump-nobump, awaiting test results.

@etobella
Copy link
Member

etobella commented Jan 2, 2026

/ocabot migration base_technical_user

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jan 2, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 2, 2026
40 tasks
@OCA-git-bot OCA-git-bot merged commit d007758 into OCA:19.0 Jan 2, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1718574. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.