[19.0][MIG] bus_alt_connection

[RabbitJon-S73]

Standard migration to 19.0

[sbiosca-s73]

LGTM!

[Reyes4711-S73]

@OCA/server-environment-maintainers please, can you merge this PR?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Jortolsa-S73]

LGTM

[RabbitJon-S73]

@thomaspaulb hi! Could you validate the migration?

[thomaspaulb]

/ocabot migration bus_alt_connection

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-3399-by-thomaspaulb-bump-nobump, awaiting test results.

[OCA-git-bot]

@thomaspaulb your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-3399-by-thomaspaulb-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[thomaspaulb]

@RabbitJon-S73 Do you get this click-contrib-make-pot error on your local also?

[RabbitJon-S73]

@RabbitJon-S73 Do you get this click-contrib-make-pot error on your local also?

No, it didn't happen to me. I'm not sure about what I have to do. Could you give me a hint? @thomaspaulb

[thomaspaulb]

@sbidoul It looks like this is the problem:

After which lang_export.data pops up as False and there is the bool error here

I can reproduce on my local if I install bus_alt_connection on an otherwise empty demo database and then run

click-odoo-makepot --addons-dir auto/addons -d $DATABASE --msgmerge-if-new-pot --commit --log-level=debug

Is this a known issue? I don't see it in https://github.com/acsone/click-odoo-contrib/issues

[sbidoul]

This is being handled here: acsone/click-odoo-contrib#173

[sbidoul]

click-odoo-contrib 1.23.1 has been released with a fix for empty .pot files in Odoo 19. Please retry the merge.

[thomaspaulb]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3399-by-thomaspaulb-bump-nobump, awaiting test results.

[thomaspaulb]

Thank you @sbidoul

[OCA-git-bot]

Congratulations, your PR was merged at dba763d. Thanks a lot for contributing to OCA. ❤️