[19.0][MIG] auditlog: Migration to 19.0 #3483

StefanRijnhart · 2026-01-02T19:50:37Z

Continued from #3391

Regular API changes and improved tests taken from [19.0][MIG] auditlog: Migration to 19.0 #3391
Adapt ThrowAwayCache to modified caching internals in Odoo. Since odoo/odoo@670897c6dc8e7, env.transaction.cache is no longer a data store.
Redistribute code and views into one file per model. Update view file names to fit the convention.
Trade slightly misleading 'Subscribe' terminology by 'Confirm'.
Small improvements to help strings and readme.
Renewed screenshot images.
Squashed a number of administrative commits.
Improved test coverage further.
Fix issue where inherited test methods are not run since Odoo 18 (backported in [18.0][FIX] auditlog: ensure methods from test template are actually run #3485)

StefanRijnhart · 2026-01-02T21:27:45Z

/ocabot migration auditlog

StefanRijnhart · 2026-01-03T14:34:54Z

test_auditlog for 19.0 is green at #3484

hbrunn · 2026-01-09T04:41:52Z

auditlog/models/rule.py

+        self._transaction.protected = StackMap["Field", OrderedSet["IdType"]]()
+        self._transaction.tocompute = defaultdict["Field", OrderedSet["IdType"]](
+            OrderedSet
+        )


I suggest using something like

def copy_empty_defaultdict(_dict): return type(_dict)(_dict.default_factory)

for all defaultdicts here. This way we don't run into subtle errors if the default factory changes in core, or type hints actually do something and change

Thanks for the suggestion! I've taken a more naive approach using copy + clear: https://github.com/OCA/server-tools/compare/8b2af873bdee80d05eb3d1b10e68cd1dedf65644..8976baea64f9d1528da855809e2e6a3e4b19363f. It seems to work for the StackMap instance as well. Do you agree with this implementation?

(rebased to fix codecov's project coverage relative to the last build of the target branch, which had progressed in the mean time).

hmm, the shallow copy looks innocent enough. do we have any measurements how expensive this is?

… module

…file

… ones to make overridding easier

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/

Currently translated at 97.7% (85 of 87 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/tr/

…ecuted by an onchange function

[IMP] auditlog: Add name to action for UX

…ain cache clean

Currently translated at 100.0% (91 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/it/

Currently translated at 95.6% (87 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/tr/

Though TransactionCase rolls back database changes, it does not call `unlink` on `auditlog.rule` records, meaning that `unsubscribe` is never called to unpatch model methods. This causes subsequent tests in other modules to unexpectedly execute patched methods. This commit adds the `AuditLogRuleCommon` test class in an attempt to identify and prevent patched methods from contaminating the test environment.

Steps to Reproduce: Install auditlog and purchase_tier_validation. Create an auditlog rule on the Tier Exception model. Create a new tier exception record for the purchase order model without any fields. In an export, check the value for the stored computed field `model_name`. Desired outcome: The value for `model_name` is 'purchase.order'. Actual outcome: There is no value for the stored computed field `model_name`. When trying to edit the `Fields` model, which depends on a valid value for this field, an error occurs saying 'Compute method failed to assign tier.validation.exception(1,).valid_model_field_ids'. Analysis: When `read` is executed under the scope of the new `ThrowAwayCache` decorator (OCA#3374), recomputes may be performed and dequeued from `self.env.cache.transaction.tocompute`. To make sure the recomputed values still end up in the non-volatile as well, we need to preserve the tocompute attribute from the original transaction.

Currently translated at 96.7% (88 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/ja/

Currently translated at 100.0% (91 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/it/

Currently translated at 95.6% (87 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/sv/

Fixes OCA#3424 Previous approach was to create a copy, so that the recomputes were also applied to the real world cache. However, this causes an issue when a field is required that is only available in the real world cache, such as the `date` field in ``` @api.depends('date', 'sequence') def _compute_internal_index(self): for st_line in self.filtered(lambda line: line._origin.id): st_line.internal_index = f'{st_line.date.strftime("%Y%m%d")}' ... ``` It actually makes sense to avoid recomputes in this isolated environment that is meant to retrieve the original values from before the write. Fixes ``` File "/odoo/odoo/addons/account/models/account_bank_statement_line.py", line 427, in create st_line.move_id.write(to_write) File "/odoo/server-tools/auditlog/models/rule.py", line 464, in write_full old_values = {d["id"]: d for d in records_write.read(fields_list)} ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/odoo/server-tools/auditlog/models/rule.py", line 406, in read result = read.origin(self, fields, load, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/odoo/odoo/odoo/models.py", line 3857, in read self._origin.fetch(fields) File "/odoo/odoo/odoo/models.py", line 4153, in fetch fetched = self._fetch_query(query, fields_to_fetch) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/odoo/odoo/odoo/models.py", line 4264, in _fetch_query field.read(fetched) File "/odoo/odoo/odoo/fields.py", line 4654, in read lines = comodel.search_fetch(domain, field_names) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/odoo/odoo/odoo/models.py", line 1781, in search_fetch return self._fetch_query(query, fields_to_fetch) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/odoo/odoo/odoo/models.py", line 4240, in _fetch_query rows = self.env.execute_query(query.select(*sql_terms)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/odoo/odoo/odoo/api.py", line 992, in execute_query self.flush_query(query) File "/odoo/odoo/odoo/api.py", line 984, in flush_query self[model_name].flush_model(field_names) File "/odoo/odoo/odoo/models.py", line 6768, in flush_model self._recompute_model(fnames) File "/odoo/odoo/odoo/models.py", line 7332, in _recompute_model self._recompute_field(field) File "/odoo/odoo/odoo/models.py", line 7360, in _recompute_field field.recompute(records) File "/odoo/odoo/odoo/fields.py", line 1471, in recompute apply_except_missing(self.compute_value, recs) File "/odoo/odoo/odoo/fields.py", line 1444, in apply_except_missing func(records) File "/odoo/odoo/odoo/fields.py", line 1493, in compute_value records._compute_field_value(self) File "/odoo/odoo/odoo/models.py", line 5297, in _compute_field_value fields.determine(field.compute, self) File "/odoo/odoo/odoo/fields.py", line 110, in determine return needle(*args) ^^^^^^^^^^^^^ File "/odoo/odoo/addons/account/models/account_bank_statement_line.py", line 295, in _compute_internal_index st_line.internal_index = f'{st_line.date.strftime("%Y%m%d")}' \ ^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'bool' object has no attribute 'strftime' ```

Co-authored-by: Eric Lembregts <[email protected]> Co-authored-by: Raf Ven <[email protected]>

…ventions

The concept of subscriptions is slightly misleading in the auditlog domain because users do not 'subscribe' to individual rules and no notifications are being sent out.

Since odoo/odoo@6dc96811c24ec, test methods from inherited test classes are not run by default.

StefanRijnhart force-pushed the 19.0-mig-auditlog branch 6 times, most recently from 32d9e39 to 3b60fc5 Compare January 2, 2026 20:17

StefanRijnhart changed the title ~~[19.0][MIG] auditlog; Migration to 19.0~~ [19.0][MIG] auditlog: Migration to 19.0 Jan 2, 2026

StefanRijnhart mentioned this pull request Jan 2, 2026

[19.0][MIG] test_auditlog: Migration to 19.0 #3484

Open

1 task

StefanRijnhart force-pushed the 19.0-mig-auditlog branch 2 times, most recently from 16d7007 to 292d89c Compare January 2, 2026 21:06

StefanRijnhart mentioned this pull request Jan 2, 2026

[19.0][MIG] auditlog: Migration to 19.0 #3391

Closed

OCA-git-bot added this to the 19.0 milestone Jan 2, 2026

OCA-git-bot mentioned this pull request Jan 2, 2026

Migration to version 19.0 #3400

Open

40 tasks

StefanRijnhart force-pushed the 19.0-mig-auditlog branch 8 times, most recently from 065c19e to 8b2af87 Compare January 3, 2026 22:58

hbrunn requested changes Jan 9, 2026

View reviewed changes

StefanRijnhart force-pushed the 19.0-mig-auditlog branch from 8b2af87 to 8976bae Compare January 11, 2026 16:19

sebalix added 5 commits January 11, 2026 17:27

[ADD] Module 'auditlog' - A substitute to the deprecated 'audittrail'…

a1db0d1

… module

[FIX] Module 'auditlog' - Fix some flake8 errors

5845acb

[FIX] Module 'auditlog' - Put the module description in a README.rst …

7915d2c

…file

[ADD] Module 'auditlog' - 'auditlog.pot' file added

d811264

[IMP] Module 'auditlog' - Split the 'create_logs()' method in several…

ea7c4e1

… ones to make overridding easier

lembregtse and others added 29 commits January 11, 2026 17:27

[MIG] auditlog: Migration to 18.0

01a87b2

[FIX] auditlog: Dismiss logging when not needed.

b49268b

[FIX] auditlog: patch away all write overrides in res.groups for test

6a639f0

[FIX] auditlog: adapt exclude fields test to OCA#3137

e429050

[UPD] Update auditlog.pot

c2de939

[BOT] post-merge updates

d835be8

Update translation files

fd06e63

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/

Translated using Weblate (Turkish)

ce26d91

Currently translated at 97.7% (85 of 87 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/tr/

[FIX] auditlog rule: Control the write function in the models when ex…

5229881

…ecuted by an onchange function

[18.0] auditlog: Log exports

334f2f0

[IMP] auditlog: Add name to action for UX

[ADD] test_auditlog

01d15ee

[FIX] auditlog: use a throwaway cache instead of trying to keep the m…

ad06512

…ain cache clean

Translated using Weblate (Italian)

809aab7

Currently translated at 100.0% (91 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/it/

Translated using Weblate (Turkish)

b4dca87

Currently translated at 95.6% (87 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/tr/

[FIX] auditlog: Ensure display_name computation works with new record.

dacc577

[REF] Remove deprecated name_get methods (odoo/odoo#122085)

5b8379b

Translated using Weblate (Japanese)

2ce40b0

Currently translated at 96.7% (88 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/ja/

Translated using Weblate (Italian)

deee194

Currently translated at 100.0% (91 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/it/

Translated using Weblate (Swedish)

7618fa8

Currently translated at 95.6% (87 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/sv/

[IMP] auditlog: pre-commit execution

9f78543

[MIG] auditlog: Migration to 19.0

e1aa0c7

Co-authored-by: Eric Lembregts <[email protected]> Co-authored-by: Raf Ven <[email protected]>

[REF] auditlog: apply one model per file convention + file naming con…

4a2e70e

…ventions

[IMP] auditlog: various usability improvements

f26a3fd

[IMP] auditlog: replace 'Subscribed' terminology by 'Confirmed'

7f5b78f

The concept of subscriptions is slightly misleading in the auditlog domain because users do not 'subscribe' to individual rules and no notifications are being sent out.

[IMP] auditlog: improve coverage

903b380

[FIX] auditlog: ensure methods from test template are actually run

07152a1

Since odoo/odoo@6dc96811c24ec, test methods from inherited test classes are not run by default.

StefanRijnhart force-pushed the 19.0-mig-auditlog branch from 8976bae to 07152a1 Compare January 11, 2026 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[19.0][MIG] auditlog: Migration to 19.0 #3483

[19.0][MIG] auditlog: Migration to 19.0 #3483

StefanRijnhart commented Jan 2, 2026 •

edited

Loading

Uh oh!

StefanRijnhart commented Jan 2, 2026

Uh oh!

StefanRijnhart commented Jan 3, 2026

Uh oh!

hbrunn Jan 9, 2026

Uh oh!

StefanRijnhart Jan 11, 2026

Uh oh!

StefanRijnhart Jan 11, 2026

Uh oh!

hbrunn Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

[19.0][MIG] auditlog: Migration to 19.0 #3483

Are you sure you want to change the base?

[19.0][MIG] auditlog: Migration to 19.0 #3483

Conversation

StefanRijnhart commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Jan 2, 2026

Uh oh!

StefanRijnhart commented Jan 3, 2026

Uh oh!

hbrunn Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

hbrunn Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

StefanRijnhart commented Jan 2, 2026 •

edited

Loading