Skip to content

Conversation

@jcadhoc
Copy link

@jcadhoc jcadhoc commented Nov 5, 2025

No description provided.

legalsylvain and others added 30 commits November 5, 2025 19:36
…avoid incompatibilities with data from those users.
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/tr/
Currently translated at 18.6% (8 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sl/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/es/
Currently translated at 58.1% (25 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
Currently translated at 95.3% (41 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/fr/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/de/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/
Currently translated at 100.0% (44 of 44 strings)

Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/es_MX/
Currently translated at 100.0% (44 of 44 strings)

Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-18.0/server-ux-18.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-server_action_mass_edit/
Currently translated at 100.0% (44 of 44 strings)

Translation: server-ux-18.0/server-ux-18.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-server_action_mass_edit/it/
@jcadhoc jcadhoc force-pushed the 19.0-mig-server_action_mass_edit branch from 31d05b5 to a7f040f Compare November 5, 2025 20:04
@legalsylvain legalsylvain marked this pull request as draft November 5, 2025 20:17
Copy link

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reyes4711-S73
Copy link

Reyes4711-S73 commented Nov 11, 2025

@jcadhoc Functional review Ok. It's working fine.
Please, can you solve pre-commit and tests errors?

@em230418
Copy link

Should we wait for finishing migration in this PR or I can start porting this module (after customer agrees) myself?

@jcadhoc jcadhoc force-pushed the 19.0-mig-server_action_mass_edit branch 8 times, most recently from 963c1b1 to a784fe1 Compare November 27, 2025 13:55
@jcadhoc jcadhoc force-pushed the 19.0-mig-server_action_mass_edit branch 2 times, most recently from 0f8ad1b to 3de676d Compare November 27, 2025 14:09
@jcadhoc jcadhoc marked this pull request as ready for review November 27, 2025 14:16
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rven
Copy link
Contributor

rven commented Jan 8, 2026

@jcadhoc Can you please follow the guidelines when migrating a module?

[IMP] : pre-commit auto fixes -> contains also the migration stuff.

Follow the Full Process documented in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

]
},
"demo": ["demo/mass_editing.xml"],
"external_dependencies": {"python": ["openupgradelib"]},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this external_dependencies needed? No migrations scripts are in place at the moment.

Comment on lines 43 to 59
<record id="mass_editing_user_line_8" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__title" />
</record>
<record id="mass_editing_user_line_9" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__company_type" />
</record>
<record id="mass_editing_user_line_10" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__image_1920" />
<field name="widget_option">image</field>
</record>
<record id="mass_editing_user_line_11" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__bank_ids" />
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValueError: External ID not found in the system: base.field_res_users__title

Suggested change
<record id="mass_editing_user_line_8" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__title" />
</record>
<record id="mass_editing_user_line_9" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__company_type" />
</record>
<record id="mass_editing_user_line_10" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__image_1920" />
<field name="widget_option">image</field>
</record>
<record id="mass_editing_user_line_11" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__bank_ids" />
</record>
<record id="mass_editing_user_line_8" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__company_type" />
</record>
<record id="mass_editing_user_line_9" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__image_1920" />
<field name="widget_option">image</field>
</record>
<record id="mass_editing_user_line_10" model="ir.actions.server.mass.edit.line">
<field name="server_action_id" ref="mass_editing_user" />
<field name="field_id" ref="base.field_res_users__bank_ids" />
</record>

… fields

When fields=None or fields=[] is passed to read(), explicitly provide
the list of real model fields from _fields.keys() to avoid Odoo trying
to read dynamic fields that may be in the record cache but not in _fields.
@jcadhoc jcadhoc force-pushed the 19.0-mig-server_action_mass_edit branch from 3de676d to 0b65ecc Compare January 14, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.