[18.0][FIX] base_tier_validation_forward: fix multiple reviews in 'pending' after forward #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @LoisRForgeFlow, @kittiu, |
Contributor
|
Hi @kittiu, @LoisRForgeFlow, |
Fixes ``` Got duplicate key in t-foreach ``` when rendering the `Reviews` section of a record under validation after one of the reviews has been forwarded. The forward is created with the same sequence as the forwarded record.
By ordering only by sequence, the order is not deterministic when there are forwards, because the forwards are created with the same sequence as the forwarded reviews.
… after forward How to reproduce: * Create two reviews for the same model with different sequences and `Approve by sequence` enabled. * Request validation on a record. Let the user of the first review forward the first validation. Desired result: The new (forward) review is in state 'pending', and the remaining review is in state 'waiting'. Actual result: Both the new (forward) review and the remaining review are in state 'pending'. Suggested solution: _compute_can_review has to be deferred during the fowarding process. It was called explicitely afterwards already.
StefanRijnhart
force-pushed
the
18.0-fix-base_tier_validation_forward-approval_sequence_violation
branch
from
9b8c6b5 to
b9c9254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Approve by sequenceenabled.first validation.
Desired result:
The new (forward) review is in state 'pending', and the remaining review is in state 'waiting'.
Actual result:
Both the new (forward) review and the remaining review are in state 'pending'.
Suggested solution:
_compute_can_reviewhas to be deferred during the fowarding process. It was called explicitely afterwards already.