[16.0][FIX] base_cancel_confirm: Fix missing fields in models dict #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @kittiu, |
When base_cancel_confirm adds fields to XML via get_view(), it must also add those fields to the models dictionary. The previous code skipped merging when the model already existed, causing JavaScript errors like: "Missing field string information for the field 'cancel_confirm'" This fix merges the new fields with existing ones instead of skipping them. Closes OCA#1190
risto42
force-pushed
the
16.0-fix-base-cancel-confirm-fields
branch
from
3f40f58 to
bad502c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190
When
base_cancel_confirminjects fields into view XML, those fields must also be added to the models dictionary returned byget_view().The bug: Lines 72-77 skipped merging fields when the model already existed:
This caused JavaScript errors:
The fix: Merge new fields with existing ones instead of skipping.
Impact: All models using
base.cancel.confirm(account.payment, account.move, sale.order, purchase.order, etc.)Testing: Verified with account.payment forms - no more JS errors.