[16.0][IMP] template_content_swapper: add feature to use domain for applying some specific records in report pdfs #1202
+133
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @yostashiro, |
AungKoKoLin1997
force-pushed
the
5806.0-imp-template_content_swapper
branch
from
37dd178 to
66d7202
Compare
AungKoKoLin1997
force-pushed
the
5806.0-imp-template_content_swapper
branch
from
66d7202 to
c31ed12
Compare
AungKoKoLin1997
force-pushed
the
5806.0-imp-template_content_swapper
branch
from
c31ed12 to
6aafaa0
Compare
yostashiro
approved these changes
Jan 8, 2026
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
@AungKoKoLin1997 I've refactored the code. Please review my commit and squash.
…g some specific records in report pdfs Co-authored-by: Yoshi Tashiro <[email protected]>
AungKoKoLin1997
force-pushed
the
5806.0-imp-template_content_swapper
branch
from
2d16fb0 to
503dd4e
Compare
Contributor
Author
@yostashiro Thanks for the refactoring code. |
|
LGTM |
nobuQuartile
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an improvement to restrict the applying changes only for some specific records by adding domain in configuration.
With this changes, we can only adjust the content of report pdf depends on some condition, not globally.
@qrtl QT5806