-
-
Notifications
You must be signed in to change notification settings - Fork 699
[17.0][ADD] social_media_* #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
1b61209 to
e77c65d
Compare
4120ccd to
a219e0b
Compare
|
The tests are experiencing issues due to the mail_print module, so they are not displaying correctly. The PR could be reviewed while the previous issue is resolved. |
93bfdea to
d00ea69
Compare
|
Modules will be renamed to social_oca_* |
Hello @Christian-RB , ok I'll change it. |
|
I still prefer |
|
I thought that adding the |
|
Les change it to social_media_* |
|
Let me clarify why I prefer
|
Not really mandatory. This is when no better name is found, and we can't (or shouldn't) reuse the same name. But we have plenty of examples where if there's better name, we use it, like |
|
Loved the dictionary entries, thanks for the explanation @pedrobaeza, if that's not mandatary I'm totally ok with using |
|
It's no bother @Christian-RB, any clarification is welcome, thanks everyone. |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some basic comments I saw on the first review
Hi @etobella , thanks for your comments. Ready for review. |
...edia_base/static/src/components/social_network_ads_account/social_network_ads_account.esm.js
Show resolved
Hide resolved
kobros-tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8bc311f to
f2a00da
Compare
|
nice, I could contribute to add facebook if you are not planning for? |
|
That sounds great! |
|
Hi @kobros-tech , do you have your host listed in your LinkedIn account's allowed URLs? Otherwise, it won't redirect you. |
|
Example @kobros-tech For example, you could simply change http://localhost:17069 to your host. |
|
all right first we would update the readme as follows: Go to Settings → Technical → System Parameters. Search for web.base.url Edit the value to: https:// This one because the default record is http:odoo which is not making sense! then the the scopes are causing error, can be because I didn't set all features from linkedin and we have to handle this. "GET /linkedin/callback?error=unauthorized_scope_error&error_description=Scope+%26quot;r_ads%26quot;+is+not+authorized+for+your+application&state=d12540d2350aafa1c7edb537d35296c3f953b974071821cce18614f58ea5a73e HTTP/1.0" |
|
here is my copy of the PR branch with fixes: https://github.com/OCA/social/pull/1622/files I will be using from now so far until the project gets merged. |
|
Hi @kobros-tech , I made some changes to the readme to make the configuration more understandable. Please give me your feedback. Thanks. |
|
i'd love to try this but my project at 18.0 branch |
|
@BinhexTeam @Christian-RB don't you guys think the models could / should be more DRY? most social accounts are linked via OAuth2 so you don't need to add a bunch of fields for each social account onto the model. why not go for social credential / social provider model similar to this? |
|
maybe even an OCA module for oauth_account similar like Google Calendar does it |
2dec543 to
1dc7260
Compare
|
You have introduce a merge commit inside the PR. Please remove it doing a proper rebase with the possible conflict solution. |
1dc7260 to
4a030e4
Compare
4a030e4 to
f66fac8
Compare
f66fac8 to
acf4b77
Compare
1b3af6a to
f91f90c
Compare
510a297 to
9e7331c
Compare
…mpaign groups, campaigns, and ads
65d6cc3 to
649bb37
Compare


@BinhexTeam
This PR allows you to manage your LinkedIn and X social networks, including posts, likes, comments, campaigns, and campaign groups.
Modules:
social_media_base: Common configurations and structures. Charts and reports.
social_media_linkedin: Management of posts, likes, comments, campaign groups, campaigns, and ads.
social_media_x: Management of posts, likes, and comments.
social_media_calendar: Add calendar view to posts