[MIG][18.0] stock_available_to_promise_release_carrier_alternative (was delivery_carrier_preference) #17

mmequignon · 2025-07-11T11:54:14Z

Was hosted on https://github.com/OCA/wms
Module was named delivery_carrier_preference

Depends on

stock_available_to_promise_release_carrier_alternative/models/stock_location_route.py

stock_available_to_promise_release_carrier_alternative/models/stock_move.py

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

stock_available_to_promise_release_carrier_alternative/models/stock_move.py

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

stock_available_to_promise_release_carrier_alternative/readme/CONTRIBUTORS.md

stock_available_to_promise_release_carrier_alternative/__manifest__.py

stock_available_to_promise_release_carrier_alternative/models/stock_move.py

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

stock_available_to_promise_release_carrier_alternative/models/stock_location_route.py

stock_available_to_promise_release_carrier_alternative/models/stock_move.py

jbaudoux

There is nothing left from delivery_carrier_preference. I don't think it makes sense to consider it as a migration of that module especially that there is no migration script.

I would drop the complete history from delivery_carrier_preference

stock_available_to_promise_release_carrier_alternative/models/stock_move.py

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

stock_available_to_promise_release_carrier_alternative/readme/CONFIGURE.md

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

stock_available_to_promise_release_carrier_alternative/__manifest__.py

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

jbaudoux · 2025-10-25T12:13:00Z

I removed the estimated weight and volume that is not necessary to compute the alternative carrier as the moves are put in a new picking to test weight and volume. Feature has been saved in this new module:

[18.0][ADD] stock_available_to_promise_release_weight_volume #37

jbaudoux · 2025-10-25T12:27:03Z

stock_available_to_promise_release_carrier_alternative/models/delivery_carrier.py

+    picking_domain = fields.Char(
+        default="[]",
+        help="Domain to restrict application of this preference "
+        "for carrier selection on pickings",
+    )
+
+    def _match_picking(self, picking):
+        res = super()._match_picking(picking)
+        if domain := const_eval(self.picking_domain):
+            return res and bool(picking.filtered_domain(domain))
+        return res


I would drop this from this module. If there is an additional restriction, it should not only apply here but also on sales carrier selection. Also the module delivery_carrier_picking_valid is already responsible of validating the carrier. This module should only rely on that other module.

jbaudoux · 2025-10-25T15:01:02Z

Add support to manage the route of the new carrier

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py

…ment group

Dropped dependency on delivery_total_weight_from_packaging. No need for what is done here. And reviewed tests and coverage.

…er link Set proper backorder link

… route Apply the carrier route when the alternative has routes set

Apply the alternative carrier before updating the date as the carrier may have an impact on the new date (see stock_release_channel module). Allow to control what is further released after the carrier has been changed.

Fix unreleasing and then releasing again: keep move in already released delivery. Also if picking contains a cancel move. Co-author: Jacques-Etienne Baudoux (BCIM) <[email protected]>

Drop additional domain from this module

Fix tests after change on backorder links with split order in stock_available_to_promise_release

jbaudoux

@simahawk Can you update your review on this one? For me, all issues have been solved

simahawk · 2025-10-30T12:12:47Z

/ocabot merge nobump

OCA-git-bot · 2025-10-30T12:12:54Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-17-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-10-30T12:19:51Z

Congratulations, your PR was merged at 2cccae1. Thanks a lot for contributing to OCA. ❤️

Signed-off-by sebalix

mmequignon force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch 2 times, most recently from 64c97f1 to 9ac776e Compare July 15, 2025 15:31

simahawk changed the title ~~[MIG][18.0] stock_available_to_promise_release_carrier_alternative~~ [MIG][18.0] stock_available_to_promise_release_carrier_alternative (was delivery_carrier_preference) Jul 16, 2025

simahawk requested changes Jul 16, 2025

View reviewed changes

jbaudoux requested changes Jul 16, 2025

View reviewed changes

jbaudoux reviewed Jul 16, 2025

View reviewed changes

mmequignon force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch from 9ac776e to b1229bb Compare July 16, 2025 11:44

jbaudoux reviewed Jul 18, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/models/stock_move.py Outdated Show resolved Hide resolved

jbaudoux reviewed Jul 18, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py Outdated Show resolved Hide resolved

jbaudoux reviewed Jul 18, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/readme/CONFIGURE.md Outdated Show resolved Hide resolved

jbaudoux reviewed Jul 18, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py Show resolved Hide resolved

mmequignon force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch 7 times, most recently from 16b44b2 to 6ac79b6 Compare July 23, 2025 07:56

jbaudoux reviewed Aug 5, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/__manifest__.py Outdated Show resolved Hide resolved

jbaudoux reviewed Aug 12, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py Outdated Show resolved Hide resolved

jbaudoux reviewed Aug 12, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py Outdated Show resolved Hide resolved

jbaudoux force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch from 5fbec27 to bc73477 Compare October 25, 2025 11:56

jbaudoux mentioned this pull request Oct 25, 2025

[18.0][ADD] stock_available_to_promise_release_weight_volume #37

Open

jbaudoux force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch from bc73477 to edbaa9f Compare October 25, 2025 12:17

jbaudoux reviewed Oct 25, 2025

View reviewed changes

jbaudoux force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch from edbaa9f to d73aef6 Compare October 25, 2025 14:56

jbaudoux mentioned this pull request Oct 25, 2025

[18.0][ADD] stock_release_channel_carrier_alternative OCA/stock-logistics-release-channel#38

Open

jbaudoux reviewed Oct 29, 2025

View reviewed changes

stock_available_to_promise_release_carrier_alternative/models/stock_picking.py Outdated Show resolved Hide resolved

grindtildeath and others added 6 commits October 29, 2025 10:43

[ADD] stock_available_to_promise_release_carrier_alternative

9265cf8

[FIX] stock_available_to_promise_release_carrier_alternative: procure…

9b0a855

…ment group

[FIX] stock_available_to_promise_release_carrier_alternative: dependency

bd515c3

Dropped dependency on delivery_total_weight_from_packaging. No need for what is done here. And reviewed tests and coverage.

[IMP] stock_available_to_promise_release_carrier_alternative: backord…

dba9a52

…er link Set proper backorder link

[IMP] stock_available_to_promise_release_carrier_alternative: carrier…

724d3e8

… route Apply the carrier route when the alternative has routes set

jbaudoux force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch 2 times, most recently from df10db7 to 5509b53 Compare October 29, 2025 09:47

[FIX] stock_available_to_promise_release_carrier_alternative: re-release

c62646e

Fix unreleasing and then releasing again: keep move in already released delivery. Also if picking contains a cancel move. Co-author: Jacques-Etienne Baudoux (BCIM) <[email protected]>

jbaudoux force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch from 5509b53 to c22424c Compare October 29, 2025 09:49

stock_available_to_promise_release_carrier_alternative: domain

6c65997

Drop additional domain from this module

jbaudoux force-pushed the 18.0-stock_available_to_promise_release_carrier_alternative branch from c22424c to 6c65997 Compare October 29, 2025 09:52

stock_available_to_promise_release_carrier_alternative: fix tests

433e0b5

Fix tests after change on backorder links with split order in stock_available_to_promise_release

jbaudoux approved these changes Oct 29, 2025

View reviewed changes

simahawk approved these changes Oct 30, 2025

View reviewed changes

OCA-git-bot added the approved label Oct 30, 2025

OCA-git-bot added the bot is merging ⏳ label Oct 30, 2025

OCA-git-bot merged commit d48edd5 into OCA:18.0 Oct 30, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 30, 2025

rousseldenis pushed a commit to acsone/stock-logistics-reservation that referenced this pull request Nov 8, 2025

Merge PR OCA#17 into 18.0

ec391d5

Signed-off-by sebalix

Uh oh!

[MIG][18.0] stock_available_to_promise_release_carrier_alternative (was delivery_carrier_preference) #17

[MIG][18.0] stock_available_to_promise_release_carrier_alternative (was delivery_carrier_preference) #17

Uh oh!

Conversation

mmequignon commented Jul 11, 2025 • edited by jbaudoux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbaudoux commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbaudoux Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

jbaudoux Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

jbaudoux commented Oct 25, 2025

Uh oh!

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk commented Oct 30, 2025

Uh oh!

OCA-git-bot commented Oct 30, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mmequignon commented Jul 11, 2025 •

edited by jbaudoux

Loading

jbaudoux commented Oct 25, 2025 •

edited

Loading