[18.0][FIX]sale_stock_available_to_promise_release: Fix availability status #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
requested changes
Oct 13, 2025
Contributor
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
better but still doesn't look right
sale_stock_available_to_promise_release/models/sale_order_line.py
Outdated
Show resolved
Hide resolved
mmequignon
force-pushed
the
18.0-fix_availability_status
branch
from
b4348a7 to
deb007b
Compare
jbaudoux
reviewed
Oct 13, 2025
| available_qty += product.uom_id._compute_quantity( | ||
| move.quantity, move.product_uom, rounding_method="HALF-UP" | ||
| ) | ||
| available_qty = self.product_uom._compute_quantity( |
Contributor
There was a problem hiding this comment.
Can you refactor a bit to not convert twice?
henrybackman
approved these changes
Oct 14, 2025
mmequignon
force-pushed
the
18.0-fix_availability_status
branch
from
deb007b to
86194a8
Compare
Member
Author
|
@jbaudoux addressed your comment, can you please make another pass ? |
jbaudoux
reviewed
Dec 19, 2025
Contributor
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
The SO line uom should be the to_unit and not the from unit isn't it?
jbaudoux
reviewed
Dec 19, 2025
| continue | ||
| if move.need_release: | ||
| available_qty += self.product_uom._compute_quantity( | ||
| move.ordered_available_to_promise_uom_qty, |
Contributor
There was a problem hiding this comment.
promise_qty instead of promise_uom_qty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing availability status, cancelled moves should be ignored.
ping @jbaudoux