[18.0][FIX] web_calendar_slot_duration, web_refresher: remove broken pt_BR.po stubs - #3623
[18.0][FIX] web_calendar_slot_duration, web_refresher: remove broken pt_BR.po stubs#3623guilhermeeller-commits wants to merge 2 commits into
Conversation
The file is 0 bytes — msgfmt --check fails with 'PO file header missing or invalid' and it carries no translations. Removing it lets Weblate regenerate a valid file when translations arrive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The file has no PO header (msgfmt --check reports a fatal error) and its 2 entries are untranslated (empty msgstr). Removing it lets Weblate regenerate a valid file when translations arrive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Hi @yajo, |
OCA-git-bot
added
series:18.0
mod:web_calendar_slot_duration
| @@ -1,13 +0,0 @@ | |||
| #. module: web_refresher | |||
There was a problem hiding this comment.
Why this one is being removed?
yajo
left a comment
yajo
left a comment
There was a problem hiding this comment.
Comment 1 explains everything and is reasonable.
/ocabot merge nobump
|
This PR looks fantastic, let's merge it! |
|
@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3623-by-yajo-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@yajo I have aborted. The patch is incorrect. How adding an empty file is correct? And removing the entire .po because there's no header instead of adding the header is not the correct patch as well. |
|
Ah sorry I got confused! I thought he was removing both files, not adding one! Thanks for aborting. Regarding the removal, it might not be the best solution, but it's also true that there are no translations there, so it's a solution at least. |
|
OK about the second one to be removed not having translations, but the first one should be removed (so the patch is only to remove the second file). |
4 participants
While auditing all
pt_BR.pofiles in this repo withmsgfmt --check(gettext 0.26), two files fail with a fatal error:web_calendar_slot_duration/i18n/pt_BR.po— empty file (0 bytes)web_refresher/i18n/pt_BR.po— no PO header (PO file header missing or invalid), and both entries have emptymsgstrNeither file carries any actual translation, so removing them loses nothing and unbreaks downstream tooling that validates .po files. Weblate will regenerate valid files when pt_BR translations arrive.
One commit per module.