[16.0] [FIX] web_field_tooltip: make tooltip_show_add_helper_allowed self-readable - #3624
Open
SuShanVoong wants to merge 1 commit into
Open
[16.0] [FIX] web_field_tooltip: make tooltip_show_add_helper_allowed self-readable#3624SuShanVoong wants to merge 1 commit into
SuShanVoong wants to merge 1 commit into
Conversation
…adable The module adds the computed field `tooltip_show_add_helper_allowed` on res.users and displays it on the user form, but only registers `tooltip_show_add_helper` in the self-readable fields. When a user without `hr.group_hr_user` opens their own Preferences, the web client reads the full user form, which now includes `tooltip_show_add_helper_allowed`. Because that field was not part of `SELF_READABLE_FIELDS`, the res.users self-read exemption (base/models/res_users.py) no longer applied to the whole read, so every group-restricted field requested in the same call (e.g. the HR fields added by the `hr` module) raised an AccessError and the user got an "Access Denied" popup. Add `tooltip_show_add_helper_allowed` to `SELF_READABLE_FIELDS` (read only; it stays out of the writeable set since it is computed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
Before: 
Grabacion.de.pantalla.desde.2026-07-27.16-47-42.webmAfter: Grabacion.de.pantalla.desde.2026-07-27.16-55-00.webm |
IVA-BO
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
web_field_tooltipadds the computed fieldtooltip_show_add_helper_allowedto res.users and displays it on the user form, but onlytooltip_show_add_helperis registered inSELF_READABLE_FIELDS.When the hr module is also installed, an internal user without
hr.group_hr_userwho opens their own Preferences gets anAccessError ("Access Denied")popup. The web client reads the whole user form in a singleread()call that now includestooltip_show_add_helper_allowed; because that field is not self-readable, the res.users self-read exemption no longer applies to the call, and the HR fields that hr adds withgroups="hr.group_hr_user"raise AccessError.Steps to reproduce (runboat)
FL-703-1158