[18.0][FIX] website_form_require_legal: avoid overriding payment terms widget - #1206
Merged
OCA-git-bot merged 1 commit intoJul 22, 2026
Merged
Conversation
OCA-git-bot
added
series:18.0
mod:website_form_require_legal
carlos-lopez-tecnativa
approved these changes
Jul 22, 2026
Contributor
|
What a great day to merge this nice PR. Let's do it! |
sergio-teruel
approved these changes
Jul 22, 2026
Contributor
|
Congratulations, your PR was merged at 4deb31c. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This widget is registered using the same TermsAndConditionsCheckbox name as the native website_sale widget, so it overrides the original implementation completely.
As a result, the change event of the terms and conditions checkbox in the checkout is no longer handled and the payment button is not enabled until the payment method is selected again.
This widget should use a different registry name so both implementations can coexist.
https://github.com/odoo/odoo/blob/06361cf46237623b8232252da2a3e7763cd28cbc/addons/website_sale/static/src/js/terms_and_conditions_checkbox.js#L6
@Tecnativa TT63742
@carlos-lopez-tecnativa @eduezerouali-tecnativa please review