Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copy Button and Fix Selection All Shortcuts in Modal #376

Conversation

WanjohiSammy
Copy link
Member

@WanjohiSammy WanjohiSammy commented Jan 24, 2025

PR Description:

Added a button to copy the content of the modal.
Fixed the Ctrl+A shortcut in standard mode to select only the modal content.
Fixed the Ctrl+Shift+A shortcut in Narrator mode to select only the modal content.

Ctrl+A is being intercepted by Narrator and cannot be programmatically handled correctly. However, when you turn on scan using CAPS + SPACE bar, use Ctrl +A to select the content in the modal.

https://www.odata.org/getting-started/understand-odata-in-6-steps/

Before

1. No Copy Button

image

2. Ctrl + A in standard mode and Narrator mode (selects everything in and outside the modal)

image

After

1. Copy Button Added

image

2. Ctrl + A in standard mode and Ctrl + A in Narrator mode + Scan mode (selects only the modal content)

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • pages/getting-started/understand-odata-in-6-steps.html: Language not supported
  • public/css/site.css: Language not supported

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • pages/getting-started/understand-odata-in-6-steps.html: Language not supported
  • public/css/site.css: Language not supported
@WanjohiSammy WanjohiSammy merged commit 0227bc8 into master Feb 5, 2025
1 check passed
@WanjohiSammy WanjohiSammy deleted the fix/3069305-missing-copy-code-button-and-ctlr-a-not-working branch February 5, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants