fix(dependencies): Update dcmjs library and improve documentation links #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs canceled.
|
✅ Deploy Preview for ohif-dev canceled.
|
sedghi
changed the title
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/stuff-again
|
| Run status |
|
| Run duration | 02m 09s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4678
This pull request includes several updates primarily focused on dependency updates and documentation improvements. The most important changes include updating the
dcmjslibrary version, adding validation checks in a utility function, and correcting various documentation links.Dependency Updates:
addOns/package.json: Updateddcmjsversion from>=0.33.0to0.38.0.extensions/test-extension/package.json: Updateddcmjsversion from0.29.11to0.38.0.package.json: Updateddcmjsversion from>=0.33.0to0.38.0.Code Enhancements:
extensions/default/src/utils/validations/areAllImagePositionsEqual.ts: Added validation checks to ensurefirstImagePositionPatientandlastIppare defined before proceeding with calculations.Documentation Improvements:
platform/docs/docs/configuration/dataSources/configuration-ui.md: Corrected link to the OHIF UI customization service.platform/docs/docs/configuration/dataSources/dicom-web.md: Corrected links to the Essentials Configuration guide. [1] [2]platform/docs/docs/deployment/cors.md: Corrected link to the Docker SSL setup documentation.platform/docs/docs/migration-guide/from-v2.md: Corrected multiple links to various sections and guides. [1] [2] [3]