Skip to content

findings by fable - #6126

Draft
sedghi wants to merge 1 commit into
masterfrom
findings-by-fable
Draft

findings by fable#6126
sedghi wants to merge 1 commit into
masterfrom
findings-by-fable

Conversation

@sedghi

@sedghi sedghi commented Jul 7, 2026

Copy link
Copy Markdown
Member

What this PR does

Adds plans/ — 13 self-contained implementation plans produced by a codebase audit on 2026-07-07 (at 973631b7e). Each plan is written so an executor with no context from the audit session can run it from the plan file plus the repo, with STOP conditions and a planned-at SHA for drift detection.

plans/README.md holds the execution-order table (priority, effort, risk, dependencies, status), suggested sequencing, dependency notes, direction findings, and the list of findings considered and rejected.

Remaining plans

Plan Title Priority Effort
001 Fix study-metadata cache invalidation + rejected-promise caching P1 S
002 Restore quality gates (gitignore, husky, ESLint, typecheck) P1 M
005 Stop per-frame re-renders in orientation markers + useMeasurements P2 S
006 Cancel superseded viewport loads + guard invalidation handler P2 M
007 Preserve original errors in HangingProtocolService rethrows P2 S
008 Report real RTSTRUCT segment-loading progress P3 S
010 Fix stale Yarn/Webpack docs to match pnpm/rspack P2 S–M
011 Unit-test the DICOMweb data source query/metadata plumbing P2 M
012 Retire the legacy Cypress suite after Playwright parity P2 M
013 Characterization tests for commandsModule + CornerstoneViewportService P3 L
014 Reduce legacy @ohif/ui to one consumer + deletion decision memo P3 M
016 Upgrade i18next / react-i18next / language-detector P3 M
017 Consolidate scattered lodash.* micro-packages P3 S–M

Already shipped

Plans 003 (deploy-recipe credentials/CORS), 004 (report-only CSP), 009 (logout redirect validation), and 015 (fork-PR runner spike) landed in #6124 and are recorded as shipped in the README rather than included here.

Testing

Documentation only — no source code changes.

13 self-contained implementation plans generated from the 2026-07-07 audit
at 973631b, ordered by leverage in plans/README.md. Plans 003, 004, 009,
and 015 already shipped in #6124 and are not included.
@netlify

netlify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 98a2301
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6a4d4ade4e0bb600081b71bb
😎 Deploy Preview https://deploy-preview-6126--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sedghi
sedghi temporarily deployed to fork-pr-approval July 7, 2026 18:52 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 076c0bac-7988-4a8a-af25-1d8a2961b781

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch findings-by-fable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cypress

cypress Bot commented Jul 7, 2026

Copy link
Copy Markdown

Viewers    Run #6490

Run Properties:  status check passed Passed #6490  •  git commit 98a2301d98: docs(plans): add implementation plans from codebase audit
Project Viewers
Branch Review findings-by-fable
Run status status check passed Passed #6490
Run duration 01m 46s
Commit git commit 98a2301d98: docs(plans): add implementation plans from codebase audit
Committer Alireza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 28
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant