pgsql: track 'progress' in tx per direction - v0 #11540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11540 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.01%
==========================================
Files 923 923
Lines 248732 248749 +17
==========================================
+ Hits 205232 205238 +6
- Misses 43500 43511 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21679 |
jufajardini
force-pushed
the
pgsql-7113/v0
branch
from
ca8de24 to
4589172
Compare
|
Information: QA ran without warnings. Pipeline 21683 |
jufajardini
force-pushed
the
pgsql-7113/v0
branch
from
4589172 to
347d25b
Compare
|
Information: QA ran without warnings. Pipeline 21689 |
While PGSQL can have multiple responses within a single transaction, the current implementation can only have one request. It makes sense then to track the transaction progress per flow direction. This will help when triggering raw stream reassembly or for unidirectional transactions, and may be useful when we implement sub- protocols that can have multiple requests per transaction, as well. CancelRequests and TerminationRequests are examples of unidirectional transactions. While we know this, we can't garantee that either messages would result in early termination of existing transactions, so we skip finishing existing transactions - which shouldn't be common, regardless, as PGSQL is mostly a sequential protocol. Bug OISF#7113
Once we are tracking tx progress per-direction for PGSQL, we can trigger the raw stream reassembly for detection purposes once the transactions are completed. Task OISF#7000
jufajardini
force-pushed
the
pgsql-7113/v0
branch
from
347d25b to
7f03644
Compare
|
I think this is now ready for a review. |
|
Information: QA ran without warnings. Pipeline 21690 |
|
Lets keep a PR that has seen these force pushes as draft. |
oh, okie, sorry. |
|
Non-draft version: #11547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing to check if this is the right direction (heh)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7113
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_BRANCH=OISF/suricata-verify#1990