tests: convert DecodeEthernetTest01 to new FAIL_IF/PASS API#14818
tests: convert DecodeEthernetTest01 to new FAIL_IF/PASS API#14818NicksonKihugu wants to merge 1 commit intoOISF:mainfrom
Conversation
NicksonKihugu
force-pushed
the
convert-decode-ethernet-tests-clean
branch
from
8bab2a5 to
ae5f310
Compare
|
NOTE: This PR may contain new authors. |
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
This needs more serious attention to be able to continue.
src/decode-ethernet.c
Outdated
| Packet *p = PacketGetFromAlloc(); | ||
| if (unlikely(p == NULL)) | ||
| return 0; | ||
| FAIL_IF(unlikely(p == NULL)) |
There was a problem hiding this comment.
Also, this is missing a semicolon. What this shows is that this code was not even compiled before submitting a PR, which is not acceptable esp since this is the 2nd PR.
|
Additionally, we have a PR template that needs to be filled in when creating a PR. Please study https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html |
NicksonKihugu
force-pushed
the
convert-decode-ethernet-tests-clean
branch
from
ae5f310 to
4a48516
Compare
Signed-off-by: Nickson Kihugu <[email protected]>
NicksonKihugu
force-pushed
the
convert-decode-ethernet-tests-clean
branch
from
4a48516 to
b439b56
Compare
|
@NicksonKihugu the most important part of our contribution process is communication. Ignoring feedback and just force pushing is not the way forward. |
|
Thank you for the feedback. |
2 participants
This PR converts the DecodeEthernetTest01 unit test in src/decode-ethernet.c to the newer FAIL_IF / PASS APIThis PR converts the DecodeEthernetTest01 unit test in src/decode-ethernet.c to the newer FAIL_IF / PASS API