Closed
Conversation
ebpf program now handles 3 layers of vlan
Instead of directly accessing the field Will allow PacketTunnelType to hold the precise tunnel type like DECODE_TUNNEL_ERSPANII with a modification of PacketIsTunnelChild
Ticket: 7717 Allows for instance to process/log ARP packets over VXLAN. That means we need to decode the ethernet layer above vxlan instead of skipping it as part of the vxlan, even if the vxlan decoder still checks the ethernet layer to avoid FPs.
to save memory
catenacyber
commented
Feb 16, 2026
catenacyber
commented
Feb 16, 2026
| SCLogError("Too many BPF maps in eBPF files"); | ||
| break; | ||
| } | ||
| if (strcmp(bpf_map__name(map), "flow_table_v4") == 0) { |
Contributor
Author
There was a problem hiding this comment.
See https://github.com/OISF/suricata/pull/14820/changes#r2811731591 I wonder if we should add some magic for padding/alignment...
This was referenced Feb 16, 2026
|
Information: QA ran without warnings. Pipeline = 29617 |
|
|
||
| /* tunnel type: none, root or child */ | ||
| enum PacketTunnelType ttype; | ||
| uint8_t ttype; // enum PacketTunnelType |
Member
There was a problem hiding this comment.
We should probably also move it to the first cacheline, as there is a 2 byte gap there and this field should also not change after it has been set.
uint8_t proto; /* 44 1 */
uint8_t recursion_level; /* 45 1 */
uint16_t vlan_id[3]; /* 46 6 */
uint8_t vlan_idx; /* 52 1 */
uint8_t flowflags; /* 53 1 */
uint8_t app_update_direction; /* 54 1 */
uint8_t sig_mask; /* 55 1 */
uint16_t pkt_hooks; /* 56 2 */
/* XXX 2 bytes hole, try to pack */
// MOVE HERE?
uint32_t flags; /* 60 4 */
/* --- cacheline 1 boundary (64 bytes) --- */
struct Flow_ * flow; /* 64 8 */
uint32_t flow_hash; /* 72 4 */
uint8_t ttype; /* 76 1 */
/* XXX 3 bytes hole, try to pack */
Contributor
Author
|
Next version in #14837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7717
Describe changes:
SV_BRANCH=OISF/suricata-verify#2521
These are the first commits before #14378 with a dedicated ticket
#14369 with review taken into account