Detect transform decompress 7846 v4#14825
Closed
catenacyber wants to merge 2 commits intoOISF:mainfrom
Closed
Conversation
Ticket: 7846
Ticket: 7846
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
catenacyber
commented
Feb 16, 2026
| } | ||
|
|
||
| unsafe extern "C" fn gunzip_transform( | ||
| _det: *mut DetectEngineThreadCtx, buffer: *mut InspectionBuffer, ctx: *mut c_void, |
Contributor
Author
There was a problem hiding this comment.
For a follow-up cleanup : should we make ctx const instead of mut for Transform callback ?
Member
There was a problem hiding this comment.
I think so ya. In C we also have this as a plain void *, which should also be changed.
Contributor
Author
There was a problem hiding this comment.
victorjulien
approved these changes
Feb 16, 2026
|
Information: QA ran without warnings. Pipeline = 29615 |
Merged
Member
|
Merged in #14827, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7846
Describe changes:
gunziptransformzlib_deflatetransform (maybe we can find a better name)SV_BRANCH=OISF/suricata-verify#2882
#14678 with code review into account
max-sizeparam