Closed
Conversation
Basic v1, v2 and v3 header validation. Ticket: OISF#8262.
So 'alert igmp ...' can work.
Add rule to decoder-events.rules to match on bad checksums.
Reordering of table and switch to match switch in parser.
RGMP is a dialect of IGMP that uses the same protocol structure, but with some different values for the fields. Detect this and log it differently.
Closed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14901 +/- ##
========================================
Coverage 73.26% 73.26%
========================================
Files 993 997 +4
Lines 271862 272110 +248
Branches 48276 48340 +64
========================================
+ Hits 199177 199369 +192
- Misses 47279 47310 +31
- Partials 25406 25431 +25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 29876 |
jasonish
reviewed
Feb 25, 2026
Comment on lines
+6657
to
+6660
| "invalid_type": { | ||
| "type": "integer", | ||
| "description": "invalid IGMP type" | ||
| }, |
Member
Author
There was a problem hiding this comment.
oops no, left over from earlier version
jasonish
reviewed
Feb 26, 2026
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
Has been running fine for a while, but I don't have much IGMP.
Open
Member
Author
|
Continues in #14907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#2910
https://redmine.openinfosecfoundation.org/issues/8262
Adds decoder for IGMPv1, v2, v3, plus RGMP. Adds igmp-csum keyword, igmp.hdr sticky buffer and igmp.type keyword. Misc other additions.
#14834 rebased