Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 4053, convert unit tests to FAIL/PASS API #5495

Closed

Conversation

jufajardini
Copy link
Contributor

src/detect-msg.c - Converted statements like "if()... go to end" to the new FAIL/PASS style.

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4053

Describe changes:

  • in src/detect-msg.c converted the applicable pieces of code to be compatible with the FAIL/PASS API, deleting variables when and if they would be no longer needed after the change.

PRScript output (if applicable):

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

src/detect-msg.c - Converted statements like "if()... go to end" to the new FAIL/PASS style.
@jufajardini jufajardini requested a review from a team as a code owner October 17, 2020 20:54
@jufajardini jufajardini deleted the fail-pass-api-task-4053-v1 branch October 17, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant