Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/msg: convert to FAIL/PASS API #5505

Closed

Conversation

jufajardini
Copy link
Contributor

Issue 4053. Adjust code formatting style (wrap long lines).
Replace SigInit with DetectEngineAppendSig.

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4053

Link to previous PR:
#5502

Describe changes:

  • Wrap long lines to keep code complaint with formatting guidelines
  • Replace SigInit with DetectEngineAppendSig
  • Remove no longer necessary SigFree

PRScript output (if applicable):

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

Issue 4053. Adjust code formatting style (wrap long lines).
Replace SigInit with DetectEngineAppendSig.
@jufajardini jufajardini requested a review from a team as a code owner October 21, 2020 18:34
@jufajardini
Copy link
Contributor Author

jufajardini commented Oct 21, 2020

I've run clang and already detected what happened. Should have run it once again before submitting... Sorry for not doing that. Lesson learned for the next time...

In any case, I'll wait to check if there's anything else that I should change...

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If you do a new PR with the clang-format fixes included (same commit) then I think we're good.

@jufajardini
Copy link
Contributor Author

Replaced by #5506

@jufajardini jufajardini deleted the fail-pass-api-task-4053-v4 branch December 11, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants