Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbss: add parser tests #5692

Closed
wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

Add tests to parse_nbss_record and parse_nbss_record_partial

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

  • There isn't one

Link to previous PR:

Describe changes:

  • Add another test scenario where the packet doesn't have 'SMB'
  • Insert space after '//'
  • Fix typos

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

Add tests to parse_nbss_record and parse_nbss_record_partial
@victorjulien victorjulien mentioned this pull request Dec 30, 2020
@victorjulien
Copy link
Member

Merged in #5693, thanks!

@jufajardini jufajardini deleted the more-smb-tests-rust-v4 branch February 26, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants